Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Batch Edit: Add support for editing simple fields #5413

Open
sharadsw opened this issue Nov 25, 2024 · 2 comments · May be fixed by #5417
Open

Batch Edit: Add support for editing simple fields #5413

sharadsw opened this issue Nov 25, 2024 · 2 comments · May be fixed by #5417
Assignees
@sharadsw
Labels
1 - Enhancement Improvements or extensions to existing behavior Batch Edit
Milestone
7.9.11

Comments

@sharadsw
Copy link
Contributor

sharadsw commented Nov 25, 2024 •
edited
Loading

Component of #4929

Batch Edit Workflow

  • Create a Query for the data you want to edit
  • Click on Batch Edit in the query results
  • Update any values
  • Validate
  • Valid edited cells highlight as Updated Cell if its a simple field
  • Click on commit to apply the changes

Features

  • Users must be able to batch edit data from a query
  • Add Batch Edit as an option in the sidebar
  • Allow batch editing simple fields in a table
  • Enable rollback for edited fields
  • Add permissions for Batch Edit
    • Users without the Batch Edit permission cannot access Batch Edit

Additional context from #4929:

Modifying any field is possible, other than nodenumber, fullname, and highestchildnodenumber. If some fields get updated, only those fields are highlighted
@sharadsw sharadsw added 1 - Request A request made by a member of the community Batch Edit labels Nov 25, 2024
@sharadsw sharadsw added this to the 7.9.9 milestone Nov 25, 2024
@sharadsw sharadsw mentioned this issue Nov 25, 2024
Closed
@sharadsw sharadsw self-assigned this Nov 25, 2024
@sharadsw sharadsw linked a pull request Nov 26, 2024 that will close this issue
Open
6 tasks
@CarolineDenis CarolineDenis modified the milestones: 7.9.9, 7.9.10 Dec 3, 2024
@realVinayak
Copy link
Contributor

Not sure about the direction you'd want to go in, but, just for clarity, if you were to hardcode this to True. Hopefully the rest of the code is self-documenting like that.

specify7/specifyweb/stored_queries/batch_edit.py

Line 1108 in 2d86ba4

omit_relationships = not has_target_permission(

Hardcoding this to True will make relationships readonly. I think there's more value in it (copying values from COA to CO) etc.

it'll always make all relationships readonly be default. I added that feature bc Jim requested a permission to retrict people from arbitarily changing relationships.

@realVinayak
Copy link
Contributor

Modifying any field is possible, other than nodenumber, fullname, and highestchildnodenumber. If some fields get updated, only those fields are highlighted

This list is slightly outdated. Look at

specify7/specifyweb/stored_queries/batch_edit.py

Lines 61 to 72 in 2d86ba4

READONLY_TABLES = [*CONCRETE_HIERARCHY]
SHARED_READONLY_FIELDS = [
"timestampcreated",
"timestampmodified",
"version",
"nodenumber",
"highestchildnodenumber",
"rankid",
"fullname",
]

@CarolineDenis CarolineDenis modified the milestones: 7.9.10, 7.9.11 Dec 20, 2024
@grantfitzsimmons grantfitzsimmons added 1 - Enhancement Improvements or extensions to existing behavior and removed 1 - Request A request made by a member of the community labels Dec 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sharadsw sharadsw

Labels
1 - Enhancement Improvements or extensions to existing behavior Batch Edit
Projects
None yet
Milestone
7.9.11
Development

Successfully merging a pull request may close this issue.

Batch Edit: Support for editing basic fields specify/specify7
4 participants
@sharadsw @grantfitzsimmons @realVinayak @CarolineDenis