Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Shared WorkBench templates #4053

Open
grantfitzsimmons opened this issue Sep 29, 2023 · 5 comments
Open

Shared WorkBench templates #4053

grantfitzsimmons opened this issue Sep 29, 2023 · 5 comments
Labels
1 - Enhancement Improvements or extensions to existing behavior 2 - WorkBench Issues that are related to the WorkBench

Comments

@grantfitzsimmons
Copy link
Member

grantfitzsimmons commented Sep 29, 2023

Our admin process involves creating mapping templates for users in our master account, and currently in order to share that we have to create a second copy, apply the master mapping, then change the owner to pass it on to the users.

Repeating this for each user and for every time the mapping changes takes a lot of work! It would be nice to have a way to push these templates out to all users from our admin account where they are managed, so that any changes to templates are automatically 'transferred' through to the users.

Either having a link that we can share like saved queries, or having a "Shared" folder that we can push templates to would be a good option (based on our other request!).

Somewhat related to #4052, it would be great to have the ability to share these templates with any user in the database.

Having a list of "template" mappings when creating a new data set would be really useful.

Requested By: Dan Baker at CSIRO (Asana)

@grantfitzsimmons grantfitzsimmons added the 1 - Request A request made by a member of the community label Sep 29, 2023
@github-project-automation github-project-automation bot moved this to 📋 Backlog in Front-End Backlog Sep 29, 2023
@grantfitzsimmons grantfitzsimmons added the 2 - WorkBench Issues that are related to the WorkBench label Sep 29, 2023
@grantfitzsimmons
Copy link
Member Author

Requested By: Anu at CSIRO

@grantfitzsimmons grantfitzsimmons added this to the Grant's issue list milestone Jan 29, 2024
@grantfitzsimmons
Copy link
Member Author

If this could just be sharable like a query (so anyone can access the WorkBench data set URL and save the data set to their account)

Ideally it would be an option when a new data set is being created

@maxpatiiuk
Copy link
Member

maxpatiiuk commented Jan 30, 2024

I think the fact that we don't have read permissions for the workbench table might make this a bit trickier - unlike with query builder, you won't be able to prevent anonymous users from reading all your datasets (and since dataset id is just a sequential ID, it's quite easy to guess)
and since you can create a data set for a table you don't have permission to (the use case is a person without access preparers the dataset, and then transfers it to a person with a dataset), we couldn't restrict read based on that either

so ideally, we would fix #2813, and as part of that, would add permissions for these tables (including read tables), and then open up data sets a bit more

of course, the current implementation of query sharing is not ideal either, so it could use a bit more brainstorming (#256) (and record sets too)

or more short term, add some sort of "is public" checkbox (which seems like what you are suggesting) (like proposed for queries in #256 (comment))

fun fact: even if you remove every single permission from the user, the workbench is still accessible because we don't have a read permission for it

@grantfitzsimmons
Copy link
Member Author

Trying to help reduce the pain in my PR aimed to solve #1363

@bronwyncombs
Copy link

For CSIRO's request, they would like to be able to share the template in bulk, and it should be updated for all accessing users when edited. Ideally, the shared templates would also be read-only.

They would also like this concept implemented for sharing saved queries, which is relevant to #1146

@grantfitzsimmons grantfitzsimmons changed the title Share WorkBench templates Shared WorkBench templates Dec 19, 2024
@grantfitzsimmons grantfitzsimmons added 1 - Enhancement Improvements or extensions to existing behavior and removed 1 - Request A request made by a member of the community labels Dec 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1 - Enhancement Improvements or extensions to existing behavior 2 - WorkBench Issues that are related to the WorkBench
Projects
Status: 📋 Backlog
Development

No branches or pull requests

3 participants