Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(styles/respec.css): defer default styles to W3C #4676

Merged
merged 1 commit into from
Apr 8, 2024
Merged

Conversation

marcoscaceres
Copy link
Contributor

We should just let the W3C's base.css handle styling things on the page. That way we get consistent styling across all docs, and don't need to worry if base.css changes... and we can upstream styling issues to the W3C

Closes #4667

@sidvishnoi
Copy link
Member

I think it should still be a breaking change, as the table.simple design changed? In case people are relying on that to be styled like this..

@marcoscaceres marcoscaceres merged commit a1beae2 into main Apr 8, 2024
8 checks passed
@marcoscaceres marcoscaceres deleted the styles branch April 8, 2024 23:04
@tfrancart
Copy link

@marcoscaceres which additionnal CSS should we include to have our tables properly styled ? we use respec in a non-W3C spec (http://linked-statistics.github.io/xkos/xkos-best-practices.html) and that change broke our document. Thanks

@sidvishnoi
Copy link
Member

@tfrancart Please add following CSS to your documents

/* --- TABLE --- */
table.simple {
  border-spacing: 0;
  border-collapse: collapse;
  border-bottom: 3px solid #005a9c;
}
.simple th {
  background: #005a9c;
  color: #fff;
  padding: 3px 5px;
  text-align: left;
}
.simple th a {
  color: #fff;
  padding: 3px 5px;
  text-align: left;
}
.simple th[scope="row"] {
  background: inherit;
  color: inherit;
  border-top: 1px solid #ddd;
}
.simple td {
  padding: 3px 10px;
  border-top: 1px solid #ddd;
}
.simple tr:nth-child(even) {
  background: #f0f6ff;
}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

table.simple style is not dark-mode friendly
3 participants