Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate to rollup from webpack #2554

Closed
saschanaz opened this issue Oct 27, 2019 · 3 comments
Closed

Migrate to rollup from webpack #2554

saschanaz opened this issue Oct 27, 2019 · 3 comments

Comments

@saschanaz
Copy link
Collaborator

saschanaz commented Oct 27, 2019

#2553 needs compiling some dependencies (specifically marked and pluralize) to es modules instead of previous copydeps so that es module system can load them. Webpack does not support emitting es modules yet (webpack/webpack#2933), maybe we should migrate to rollup to do this.

(Currently #2553 uses forked ES module versions of those dependencies, but maintaining forks is a burden.)

@marcoscaceres
Copy link
Contributor

I don't mind, so long as we get a development server and don't need to (re)compile the code test it.

@saschanaz
Copy link
Collaborator Author

Compiling dependencies would happen after npm install as current copydeps do, so it shouldn't make additional burden when testing 👍

@saschanaz
Copy link
Collaborator Author

Closed by #2553

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants