Fix ReverseProxied middleware and add docs #1873
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mjp4
pushed a commit
to mjp4/connexion
that referenced
this pull request
Feb 21, 2024
Starlette introduced some new changes to how the `root_path` is handled, which broke our `ReverseProxied` example and test. This PR fixes both and adds documentation on how to run behind a proxy.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Starlette introduced some new changes to how the
root_pathis handled, which broke ourReverseProxiedexample and test.This PR fixes both and adds documentation on how to run behind a proxy.