Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Objects and Arrays recursively construct examples #1148

Merged
merged 2 commits into from
Feb 10, 2020
Merged

Objects and Arrays recursively construct examples #1148

merged 2 commits into from
Feb 10, 2020

Conversation

mjp4
Copy link
Contributor

@mjp4 mjp4 commented Feb 6, 2020

Objects and Arrays recursively construct examples from examples of their children

Fixes #409 .

Changes proposed in this pull request:

  • In MockResolver, Objects and Arrays recursively construct examples from examples of their children
  • Extra tests in test_mock.py

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.1%) to 96.144% when pulling ba1da6e on mjp4:nested_example_in_mock into 3fecd3e on zalando:master.

@coveralls
Copy link

coveralls commented Feb 6, 2020 •
edited
Loading

Coverage Status

Coverage increased (+0.05%) to 96.291% when pulling 97410e2 on mjp4:nested_example_in_mock into 3fecd3e on zalando:master.

@hjacobs
Copy link
Contributor

hjacobs commented Feb 7, 2020

Thanks!

@mjp4
Copy link
Contributor Author

mjp4 commented Feb 10, 2020

I have added two more tests to get full coverage. Who is able to approve and pull?

@hjacobs
Copy link
Contributor

hjacobs commented Feb 10, 2020

👍

@hjacobs hjacobs merged commit 96bdcb0 into spec-first:master Feb 10, 2020
@RobbeSneyders RobbeSneyders mentioned this pull request Jul 5, 2021
Closed
@mjp4 mjp4 mentioned this pull request Jul 5, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Mock Server should build response from field's example in schema
3 participants
@mjp4 @coveralls @hjacobs