Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Getting error 'skip_error_handlers' in connexion==3.0.0 but not in connexion==2.14.2 #1783

Closed
rkumar-goodrx opened this issue Nov 3, 2023 · 3 comments

Comments

@rkumar-goodrx
Copy link

Description\

We are getting Getting error 'skip_error_handlers' in connexion==3.0.0
but the error is not in connexion==2.14.2

connexion_app = App(name, specification_dir=spec_dir, skip_error_handlers=True)
E TypeError: init() got an unexpected keyword argument 'skip_error_handlers'

.tox/py38/lib/python3.8/site-packages/airflow/migrations/versions/0074_2_0_0_resource_based_permissions.py:342: in upgrade
    remap_permissions()
.tox/py38/lib/python3.8/site-packages/airflow/migrations/versions/0074_2_0_0_resource_based_permissions.py:290: in remap_permissions
    appbuilder = create_app(config={'FAB_UPDATE_PERMS': False}).appbuilder
.tox/py38/lib/python3.8/site-packages/airflow/www/app.py:143: in create_app
    init_api_connexion(flask_app)
.tox/py38/lib/python3.8/site-packages/airflow/www/extensions/init_views.py:195: in init_api_connexion
    connexion_app = App(__name__, specification_dir=spec_dir, skip_error_handlers=True)
E   TypeError: __init__() got an unexpected keyword argument 'skip_error_handlers'

Expected behaviour

It should not give error TypeError: init() got an unexpected keyword argument 'skip_error_handlers'

Actual behaviour

It should not give any errors

Steps to reproduce

connexion_app = App(name, specification_dir=spec_dir, skip_error_handlers=True)

Additional info:

Output of the commands:

  • python --version
  • pip show connexion | grep "^Version\:"
@RobbeSneyders
Copy link
Member

Hi @rkumar-goodrx, skip_error_handlers was deprecated in Connexion 3. It was undocumented and unclear why it was originally added. The way connexion registers error handlers has also been reworked.

Could you explain why you use it?

@rkumar-goodrx
Copy link
Author

@RobbeSneyders Its not used directly by us.But used by one of the external libraries related to airflow.
I would have been better if there is backward compatibility to prevent these errors.

@RobbeSneyders
Copy link
Member

RobbeSneyders commented Nov 3, 2023

We bumped the major version to indicate breaking changes. Please read this issue on the Airflow repo to understand how you can correctly install Airflow and prevent this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants