Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NodeJS 8 support #308

Closed
guybedford opened this issue Mar 8, 2017 · 2 comments
Closed

NodeJS 8 support #308

guybedford opened this issue Mar 8, 2017 · 2 comments

Comments

@guybedford
Copy link

Running the Node 8 nightly, I'm getting the following:

TypeError: this._renderHeaders is not a function
    at ServerResponse.writeHead (node_modules/spdy/lib/spdy/response.js:28:20)
    at ServerResponse._implicitHeader (_http_server.js:159:8)
    at ServerResponse.write (_http_outgoing.js:521:10)
    at ReadStream.ondata (_stream_readable.js:555:20)
    at emitOne (events.js:96:13)
    at ReadStream.emit (events.js:191:7)
    at readableAddChunk (_stream_readable.js:176:18)
    at ReadStream.Readable.push (_stream_readable.js:134:10)
    at onread (fs.js:1857:12)
    at FSReqWrap.wrapper [as oncomplete] (fs.js:591:17)

I think _renderHeaders might be deprecated?

@MylesBorins
Copy link

I'm seeing things broken with the test suite with the landing on nodejs/node#11926

did you get to the bottom of the renderHeaders problem? are there tests that cover that part of the api?

@jacobheun
Copy link
Contributor

4.0.0 includes support for the current LTS versions of node (6,8,10)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

3 participants