Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Converter from Intermediate to Main data structure #16

Merged
merged 2 commits into from
Aug 24, 2019

Conversation

abhishekspeer
Copy link
Contributor

Signed-off-by: [email protected]

Transfer script added to Converter from Intermediate to Main data structure.

@rtgdk
Copy link

rtgdk commented Aug 17, 2019

@abhishekspeer Have you changed the main function to return the main data structure instead of intermediate?
Also, add some example files to run the code.

@abhishekspeer
Copy link
Contributor Author

Thanks again @rtgdk! I've added the changes as well as referenced a seperate PR that adds example script to run the loader.

@swinslow
Copy link
Member

Overall looks good for the time being -- I'll go ahead and merge.

There are several ways that the rdfloader is still making assumptions about RDF files that are specific to the example file you were working with, which won't hold in the normal case. In particular the assumption that there will only be one Snippet is incorrect (and therefore where a pointer to one snippet is being returned by the parsing functions will not work as desired for RDF files with >1 snippets).

However, since we're keeping this within the rdfreader branch for now I'm fine with merging. Thank you @abhishekspeer!

@swinslow swinslow merged commit 820946d into spdx:rdfreader Aug 24, 2019
@swinslow swinslow added this to the 0.1.0 milestone Jul 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants