Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CodeGen bug: "Variable LLFALL has not been defined", even when it is a top-level transient array with a symbolic shape. #1735

Open
pratyai opened this issue Nov 6, 2024 · 0 comments
Labels
bug Something isn't working

Comments

@pratyai
Copy link
Collaborator

pratyai commented Nov 6, 2024

This is the smallest graph that I came up with for demo: https://polybox.ethz.ch/index.php/s/E9QxXiTLjaFfezR

In the JSON file, the LLFALL is defined at the top level as follows:

{
  "type": "SDFG",
  "attributes": {
    "name": "loop1_test_function",
    "_arrays": {

... truncated ...

      "LLFALL": {
        "type": "Array",
        "attributes": {
          "strides": [
            "1"
          ],
          "total_size": "NCLV",
          "offset": [
            "-1"
          ],
          "optional": false,
          "shape": [
            "NCLV"
          ],
          "transient": true,
          "debuginfo": null
        }
      },

... truncated ...

Furthermore:

  • While codegen throws the error while processing the state _state_l15_c15, if I remove the other branch, the compilation succeeds.
  • If I apply simplify on the original graph that I started with, the compilation succeeds too. But it produces C++ code with undefined behaviour. (Not sure if I can reproduce that for this clipped graph, but I think that's not very important since compile() should produce correct code for correct graph without any further transforms anyway).

If the input graph is wrong for some reason, please let me know.

@pratyai pratyai added the bug Something isn't working label Nov 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant