withAllTags() and withAnyTags() support slugs with hyphens?

[bartclaeys]

Are withAllTags() and withAnyTags() supposed to work with slugs as well, eg. foo-bar?

In my experience they do not, so I have to convert hyphens into spaces before using these.

[freekmurze]

They should work. If not, please submit a failing test (and possibly a fix) to demonstrate the problem.

[falconsmilie]

I have a similar issue.

This call here;

laravel-tags/src/HasTags.php

Line 76 in b210310

$tags = static::convertToTags($tags, $type);

is returning a Collection where items contains [0 => null] when querying for tags by slug. With or without type yields the same result.

Usage:

MyModel::withAllTags('myTag', 'myType')->get()

When querying a regular string it returns with an array of Tag.

composer.json excerpt

        "php": "^8.2",
        ...
        "filament/filament": "^2.0",
        "filament/notifications": "^2.0",
        "filament/spatie-laravel-tags-plugin": "^2.0",
        ...
        "laravel/framework": "^9.19",
        ...

[falconsmilie]

@bartclaeys #443