Long term idea: solutions suggestions to common errors

[raveren]

Hi, first of all, thanks for all the great work, Spatie devs!

I just found that I missed extends Data on one of the 25+ new classes I created to mirror the full DHL api rate response object, and I wish I could communicate the helplessness I felt until I solved it, all I had was

TypeError: Cannot assign array to property <redacted namespace>\Dhl\DataStructure\DhlRateResponse\DhlRateResponse_Products::$deliveryCapabilities of type <redacted namespace>\DataStructure\DhlRateResponse\DhlRateResponse_Products_DeliveryCapabilities

/var/www/vendor/spatie/laravel-data/src/Resolvers/DataFromArrayResolver.php:68
/var/www/vendor/laravel/framework/src/Illuminate/Collections/Traits/EnumeratesValues.php:238
/var/www/vendor/spatie/laravel-data/src/Resolvers/DataFromArrayResolver.php:49
/var/www/vendor/spatie/laravel-data/src/Resolvers/DataFromSomethingResolver.php:51
/var/www/vendor/spatie/laravel-data/src/Concerns/BaseData.php:52
/var/www/vendor/spatie/laravel-data/src/DataCollection.php:60
/var/www/vendor/laravel/framework/src/Illuminate/Collections/Arr.php:558
/var/www/vendor/laravel/framework/src/Illuminate/Collections/Collection.php:777
/var/www/vendor/spatie/laravel-data/src/DataCollection.php:59
/var/www/vendor/spatie/laravel-data/src/Concerns/BaseData.php:93
/var/www/vendor/spatie/laravel-data/src/DataPipes/CastPropertiesDataPipe.php:64
/var/www/vendor/spatie/laravel-data/src/DataPipes/CastPropertiesDataPipe.php:34
/var/www/vendor/spatie/laravel-data/src/Support/ResolvedDataPipeline.php:42
/var/www/vendor/spatie/laravel-data/src/Resolvers/DataFromSomethingResolver.php:46
/var/www/vendor/spatie/laravel-data/src/Concerns/BaseData.php:52

Just an idea that can save a LOT of frustration...

BTW, one small but significant upside of having the DataCollections in Data v3 is they immediately throw error if their contents do not extend Data, which prevents major headscratching later :)

[rubenvanassche]

You're always welcome to PR such a thing. I think we need to check in the DataClass class in the support dir that a class we're analyzing is somehow implementing BaseData. Since we're using that class all the time, this probably should throw an error quite quickly.