Configurable db dumper

[cretueusebiu]

How would you go about configuring the db dumper instance in the BackupJob class ?

I see there is a config option for DbDumper::useCompressor() since that's common among all db dumpers, but say for instance I want to to set MySql::skipLockTables() it wouldn't make much sense to have a config option for that since it's only for MySql.

I was thinking to use maybe an event where you pass the db dumper instance. Something like this:

event(new \Spatie\Backup\Events\DumpingDatabase($dbDumper));

$dbDumper->dumpToFile($temporaryFilePath);

//... 

namespace Spatie\Backup\Events;

use Spatie\DbDumper\DbDumper;

class DumpingDatabase
{
    public function __construct(public DbDumper $dbDumper) 
    {}
}

Now all you would need is a listener and you can call any method on the dumper.

What do you think ?