Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

For [Adding a new column for events #673] #702

Merged
merged 7 commits into from
Mar 23, 2020
Merged

For [Adding a new column for events #673] #702

merged 7 commits into from
Mar 23, 2020

Conversation

AbdullahFaqeir
Copy link
Contributor

@AbdullahFaqeir AbdullahFaqeir commented Mar 22, 2020 •
edited
Loading

Relates to #673

  • Added migration to updata activity log table to add event column.
  • Added event() & setEvent() method to the logger to set activity event.
  • Automatically set activity event based on model events.
  • Added test cases for event, and updated some of currents which used to handle events via properties.

@AbdullahFaqeir
- Added migration to updata activity log table to add event column.
1f33af0 
- Added even() & setEvent() method to the logger to set activity event.
- Automatically set activity event based on model events.
- Added test cases for event, and updated some of currents which used to handle events via properties.
@AbdullahFaqeir
- Added migration to updata activity log table to add event column.
af5e4fa 
- Added even() & setEvent() method to the logger to set activity event.
- Automatically set activity event based on model events.
- Added test cases for event, and updated some of currents which used to handle events via properties.
@AbdullahFaqeir
- Added migration to updata activity log table to add event column.
87383c6 
- Added even() & setEvent() method to the logger to set activity event.
- Automatically set activity event based on model events.
- Added test cases for event, and updated some of currents which used to handle events via properties.
@Gummibeer
Copy link
Collaborator

Hey @AbdullahFaqeir
thanks for your time and work here.
At first I want to ask you to remove the .idea - from the gitignore but also from the repo/branch.

@sebastiandedeyne wrote an awesome article about it:
https://sebastiandedeyne.com/setting-up-a-global-gitignore-file/

In addition to this: please fix the code style.
You can see what to do at StyleCI

And now I will review your changes in depth. =)

Gummibeer
Gummibeer requested changes Mar 22, 2020
View reviewed changes
migrations/update_activity_log_table.php.stub Outdated Show resolved Hide resolved
src/ActivityLogger.php Show resolved Hide resolved
src/ActivitylogServiceProvider.php Outdated Show resolved Hide resolved
src/Contracts/Activity.php Outdated Show resolved Hide resolved
tests/LogsActivityTest.php Show resolved Hide resolved
tests/LogsActivityTest.php Outdated Show resolved Hide resolved
@AbdullahFaqeir
Copy link
Contributor Author

@Gummibeer
You're most welcome, I'm pleased to help =)

I've applied all your request changed.

@AbdullahFaqeir
Copy link
Contributor Author

👍🏻

@Gummibeer Gummibeer merged commit 91aba6c into spatie:master Mar 23, 2020
@Gummibeer Gummibeer linked an issue Mar 23, 2020 that may be closed by this pull request
Adding a new column for events #673
Closed
@Gummibeer
Copy link
Collaborator

https://github.com/spatie/laravel-activitylog/releases/tag/3.14.0

@Gummibeer Gummibeer mentioned this pull request Sep 16, 2020
Merged
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Gummibeer Gummibeer Gummibeer approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Adding a new column for events
2 participants
@AbdullahFaqeir @Gummibeer