Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error in CIELab regexp #55

Closed
oy-satana opened this issue Oct 15, 2021 · 0 comments · Fixed by #61
Closed

Error in CIELab regexp #55

oy-satana opened this issue Oct 15, 2021 · 0 comments · Fixed by #61

Comments

@oy-satana
Copy link

Example
$rgb = new \Spatie\Color\Rgb(0, 0, 0); \Spatie\Color\CIELab::fromString((string) $rgb->toCIELab());

Input values are not always floats and the validator will throw exception

CIELab color string CIELab(0,0,0) is malformed. A CIELab color contains 3 comma separated values, wrapped in CIELab(), e.g. CIELab(62.91,5.34,-57.73)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant