Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DOC: link to a local file name with spaces #699

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

mgeier
Copy link
Member

@mgeier mgeier commented Jan 8, 2023

No description provided.

@smith-kyle
Copy link

I'm a little late to the party, but I noticed you all aren't using a notebook review tool and wanted to invite you to review this pull request with GitNotebooks: https://gitnotebooks.com/spatialaudio/nbsphinx/pull/699

It lets you do things like comment on rendered markdown and code cells, so might be an easy win for your PR reviews.

@mgeier
Copy link
Member Author

mgeier commented Feb 2, 2024

Thanks for the hint @smith-kyle!

Ironically, the link that this PR is all about doesn't seem to work on the service.
None of the internal links seem to work, nor does math, tables, <div> elements or links within them.

@smith-kyle
Copy link

I appreciate the feedback @mgeier! Latex equations, and github flavored tables will be supported soon

@mgeier mgeier force-pushed the local-file-with-spaces branch 2 times, most recently from 8796068 to 82dd25f Compare February 3, 2024 10:09
@mgeier mgeier marked this pull request as draft February 3, 2024 11:13
@mgeier mgeier force-pushed the local-file-with-spaces branch from 82dd25f to b729b2d Compare May 2, 2024 20:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants