-
Notifications
You must be signed in to change notification settings - Fork 132
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
timings & timestamps for input cells #686
base: master
Are you sure you want to change the base?
Conversation
Thanks for this PR! How is this related to https://github.com/deshaw/jupyterlab-execute-time? Will this work with notebook v7?
I guess not, I've never seen it.
I think this should be documented in a new notebook, maybe in this section: https://nbsphinx.readthedocs.io/executing-notebooks.html It would be good if only that one notebook shows the timings, the rest of the docs should stay unchanged. The actual option should also be mentioned at https://nbsphinx.readthedocs.io/en/0.8.10/usage.html#nbsphinx-Configuration-Values
We will see once this is part of the docs.
I think there are better ways to convey this information. Anyway, that's not really that important for the issue at hand. |
Thanks Matthias for the reply,
This works with the classic Jupyter Notebook extension, but can be adapted easily to the extension above, only have to check how it records the timestamps in the
Cool, maybe it's easier for you to edit the docs, or I can give it a try if you want
Sure, a plugin for this (and support in nbsphinx) would be great, just like the
|
Yes, please do that. I hope the two extensions are compatible.
I will try to fix the CI error (which is probably related to #687), but you should modify the docs for your new feature. The docs are at the same time tests to check if the feature works, so they should be updated together with the implementation of the feature. |
I've merged #688, now CI should work. |
execute_time
extension for Jupyter Notebook: https://jupyter-contrib-nbextensions.readthedocs.io/en/latest/nbextensions/execute_time/readme.htmlcell.metadata.ExecuteTime
, I don't know if it exists in notebooks that don't use the extensionnbsphinx_timings
option enables or disables showing the timings (not sure where to document it)The HTML output looks like this (haven't tested LaTeX):
Having the timings is highly helpful for the readers as they know what to expect, how long does it take to run the code, and tells something about the age of the content (e.g. it's too new or too old to run with a certain version, etc).