-
Notifications
You must be signed in to change notification settings - Fork 47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
dense.dot(sparse) impl #160
Conversation
That seems mostly reasonable yes, but I'm not sure I like the added genericity on |
@vbarrielle this now will compile on stable. It's not possible to have default generic types on methods, so I'm not sure how to reduce the genericity of the Any thoughts on what we could do there? |
Hello, sorry for the delayed answer. I think this added genericity is not too much of a problem, I however need to write a few examples to check if it's actually a breaking change for "typical" calls to I hope I'll find the time to do it in the coming week. |
Hello @pmarks, I've rebased and updated your branch on the latest master, and merged it manually, I'm no longer worried about a possible breaking change as I'm going to bump to 0.8 for other changes as well. I think I got the gist of your PR right, and tests look ok, but please tell me if I forgot something. After rebasing, I obtained the commits 896c7f2 and 10f42f0 |
@vbarrielle very cool, thanks!! |
This will be allowed on stable once rust-lang/rust#55437 is stabilized. Seem reasonable?