fix: avoid collision with glibc's canonicalize() method #2106
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
|
@pterjan Please give this a look and let us know whether it addresses the issue you're seeing. |
|
Code Climate has analyzed commit 7df9533 and detected 0 issues on this pull request. The test coverage on the diff in this pull request is 100.0% (80% is the threshold). This pull request will bring the total coverage in the repository to 94.3%. View more on Code Climate. |
|
✅ Build nokogiri 1.0.761 completed (commit 05d76770a3 by @flavorjones) |
|
Thank you, I can confirm the patch fixes the build here! |
|
Great, I'll merge it and it will be in the next v1.11.0 release candidate. Thank you! |
M0ses
added a commit
to M0ses/open-build-service
that referenced
this pull request
Jul 28, 2023
Fixes conflicts between nokogiri (1.10.9) and glibc SEE sparklemotion/nokogiri#2106 for more information.
M0ses
added a commit
to M0ses/open-build-service
that referenced
this pull request
Jul 28, 2023
Fixes conflicts between nokogiri (1.10.9) and glibc SEE sparklemotion/nokogiri#2106 for more information.
bergey
added a commit
to bergey/rustwasm.github.io
that referenced
this pull request
Feb 11, 2024
we're running into the issue fixed in sparklemotion/nokogiri#2106
daxpedda
pushed a commit
to rustwasm/rustwasm.github.io
that referenced
this pull request
Feb 11, 2024
* upgrade nokogiri we're running into the issue fixed in sparklemotion/nokogiri#2106 * build mdbook without search feature error is: error: failed to compile `mdbook v0.2.3`, intermediate artifacts can be found at `/tmp/cargo-installjZOKMC` Caused by: failed to select a version for the requirement `ammonia = "^1.1"` candidate versions found which didn't match: 3.3.0, 3.2.1, 3.2.0, ... I believe because ammonia-1.1 was pulled from crates.io
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2105
What problem is this PR intended to solve?
#2105
Have you included adequate test coverage?
No functional changes
Does this change affect the C or the Java implementations?
Only CRuby