Support direct combinators in CSS :has() #1895
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonathanhefner
commented
Apr 18, 2019
|
Code Climate has analyzed commit 593fae6 and detected 0 issues on this pull request. The test coverage on the diff in this pull request is 100.0% (80% is the threshold). This pull request will bring the total coverage in the repository to 93.5%. View more on Code Climate. |
|
@jonathanhefner Thanks for submitting this PR! I've added some tests that run CSS queries on a real document to make sure I understand how these pseudoselector queries work. Should be through CI shortly! |
flavorjones
force-pushed
the
fix-css-has
branch
from
8f01e8f
to
c88c9b7
Compare
flavorjones
added a commit
to jonathanhefner/nokogiri
that referenced
this pull request
Apr 22, 2019
Adds support for CSS queries like "a:has(> b)", "a:has(~ b)", and "a:has(+ b)". Closes sparklemotion#688.
so we can add more ad-hoc CSS tests there
flavorjones
force-pushed
the
fix-css-has
branch
from
8f548bf
to
593fae6
Compare
|
Sorry for the force-push, rebased onto current master. |
|
Thank you! This will be in v1.11.0 when it ships. Watch the milestone for details. |
|
@flavorjones Thank you for adding those tests and merging this in! 😃 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem is this PR intended to solve?
Adds support for CSS queries like
"a:has(> b)","a:has(~ b)", and"a:has(+ b)".Closes #688.
Have you included adequate test coverage?
Yes, I think so.
Does this change affect the C or the Java implementations?
No.