Fix broken tests under jruby 1.9 mode

[jvshahid]

@yokolet I created this ticket to synchronize the work on fixing the tests under 1.9 mode.

I fixed most of them except for the ones that have to do with encoding on the 'fix_tests_19_mode' branch. As of now the most commit is rev f156bd1.

Also I was trying to cleanup the SAX push parser to avoid the Thread.sleep by synchronizing the push parser and the SAX parser which caused some tests to hang, I'm still looking into it.

[jvshahid]

@yokolet I rebased the fix_tests_19_mode branch off of master and fixed the hanging test problem. We're down to 2 failures and 3 errors, all of them are encoding problems (except one test 'test_pp'). Take a look and let me know if we should merge the branch or wait until all tests are fixed.

[yokolet]

Woot! That's awesome.

But, did you get 2F and 3E? I got 2F and 2E. Perhaps, JRuby version is different? I'm using jruby 1.7.0.preview2.dev .

I filed pp bug in JRuby's JIRA, https://jira.codehaus.org/browse/JRUBY-6729 . This is apparently JRuby's bug.
I'm suspecting "test_encoding" error is also from JRuby and looking around JRuby code. I haven't looked at rest of two encoding bugs yet.

[jvshahid]

Yes, I'm running the tests on 1.6.7, should I be running 1.7.0 instead ?

On Fri, Jun 22, 2012 at 10:33 AM, Yoko Harada <
[email protected]

wrote:

Woot! That's awesome.

But, did you get 2F and 3E? I got 2F and 2E. Perhaps, JRuby version is
different? I'm using jruby 1.7.0.preview2.dev .

I filed pp bug in JRuby's JIRA,
https://jira.codehaus.org/browse/JRUBY-6729 . This is apparently JRuby's
bug.
I'm suspecting "test_encoding" error is also from JRuby and looking around
JRuby code. I haven't looked at rest of two encoding bugs yet.

---

Reply to this email directly or view it on GitHub:
#705 (comment)

[yokolet]

Yes, I think so. Nokogiri should work on older versions of JRuby. But, it comes to a fixing 1.9 bugs, you'd better use 1.7.0. JRuby still has not a small number of 1.9 bugs. Those are being fixed release by release. We should figure out whether the bug comes from JRuby or Nokogiri.

[yokolet]

I think this branch should be merged to master. 2F/2E is definitely better.

I pushed the fix for test_pp to JRuby master. So, now, Nokogiri's 1.9 test should have 2F/1E on JRuby head.

There are two related issues, #657 and http://jira.codehaus.org/browse/JRUBY-6729 .

[jvshahid]

Yay, we're down to 1 failure in 1.9 mode; there's a bug in 1.7.0 that fixes one encoding test, jruby/jruby#223 and https://github.com/rubyspec/rubyspec/pull/146.

[jvshahid]

It's been 7 months, but we finally did it. Java Nokogiri passing all tests under both 1.8 and 1.9 mode. Oh yeah, it feels good.

[yokolet]

Woot!