Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JRuby regressions 1.4.6 -> 1.5.0 #514

Closed
wvanbergen opened this issue Aug 10, 2011 · 2 comments
Closed

JRuby regressions 1.4.6 -> 1.5.0 #514

wvanbergen opened this issue Aug 10, 2011 · 2 comments

Comments

@wvanbergen
Copy link

Nokogiri 1.5.0 on JRuby seems to have some regressions:

  • Nokogiri::XML::Document.parse('< test />').to_s now no longer includes the encoding in the initial tag. This will cause parse issues later on when using unicode characters,
  • I am getting "called decorate on nil" exceptions that are completely unrelated to my code.

The travis CI build: http://travis-ci.org/#!/wvanbergen/adyen/builds/75767
All tests run fine when not using JRuby or when using Nokogiri 1.4.6.

@gstark
Copy link

gstark commented Nov 29, 2011

This code below produces a "called decorate on nill" exception in JRuby for me. Works fine in 1.4.6:

process_output= <<END
<test>
 <track type="Image">
 <Format>LZ77</Format>
</test>
END

doc = Nokogiri::XML.parse(process_output)

node = doc.xpath(%{//track[@type='Video']})

puts node.xpath("Format").inspect

@yokolet
Copy link
Member

yokolet commented Jun 13, 2012

I'm very sorry to get back to you so late.

@wvanbergen current pure Java version returns exactly the same result as libxml version for Nokogiri::XML::Document.parse('< test />').to_s . So, it looks the bug has been fixed along with other bug fix(es), at some point.

However, "called decorate on nil" exception still exists there. So, I fixed this bug in rev. 0b8bf4e .

Thanks, @gstark . Your code was very helpful to figure out what caused the bug.

@yokolet yokolet closed this as completed Jun 13, 2012
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants