Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bug] on JRuby, Loofah subclasses are broken #3370

Closed
flavorjones opened this issue Dec 11, 2024 · 1 comment
Closed

[bug] on JRuby, Loofah subclasses are broken #3370

flavorjones opened this issue Dec 11, 2024 · 1 comment

Comments

@flavorjones
Copy link
Member

Please describe the bug

On JRuby, running Loofah's test suite:


  1) Error:
IntegrationTestHtml::html4 fragment::#to_text#test_0001_add newlines before and after html4 block elements:
NoMethodError: undefined method `scrub!' for #<Loofah::HTML4::DocumentFragment:0x6ac4f31d>
    lib/loofah/concerns.rb:121:in `to_text'
    test/integration/test_html.rb:58:in `block in IntegrationTestHtml'

  2) Error:
IntegrationTestHtml::html4 fragment::#to_text#test_0003_remove extraneous whitespace:
NoMethodError: undefined method `scrub!' for #<Loofah::HTML4::DocumentFragment:0x13bf5fd>
    lib/loofah/concerns.rb:121:in `to_text'
    test/integration/test_html.rb:76:in `block in IntegrationTestHtml'

  3) Error:
IntegrationTestHtml::html4 fragment::#to_text#test_0002_add newlines before and after html5 block elements:
NoMethodError: undefined method `scrub!' for #<Loofah::HTML4::DocumentFragment:0x138d978e>
    lib/loofah/concerns.rb:121:in `to_text'
    test/integration/test_html.rb:67:in `block in IntegrationTestHtml'

  4) Error:
IntegrationTestHtml::html4 fragment::#to_text#test_0004_replaces <br> with newlines:
NoMethodError: undefined method `scrub!' for #<Loofah::HTML4::DocumentFragment:0x7a22302c>
    lib/loofah/concerns.rb:121:in `to_text'
    test/integration/test_html.rb:85:in `block in IntegrationTestHtml'

1055 runs, 2084 assertions, 0 failures, 4 errors, 0 skips

Additional context

I'm pretty sure this is due to changes made in #3117 to fix #316.

@flavorjones flavorjones added the state/needs-triage Inbox for non-installation-related bug reports or help requests label Dec 11, 2024
@flavorjones flavorjones added this to the v1.17.x patch releases milestone Dec 11, 2024
@flavorjones flavorjones added platform/jruby and removed state/needs-triage Inbox for non-installation-related bug reports or help requests labels Dec 11, 2024
@flavorjones
Copy link
Member Author

This was closed by #3372 and that fix shipped in v1.17.2.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant