-
-
Notifications
You must be signed in to change notification settings - Fork 901
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
On Darwin, ignore anything but system's ranlib. Fixes #1812 #1813
Conversation
This is related to #1812 |
/cc @zenspider Can you please take a look at this. |
@zenspider @flavorjones I hit this many times for each my environments... |
@nurse Can you confirm that this fix addresses your issue? I have no easy way to test. |
@nurse Now I'm curious. Do you have GNU's |
@flavorjones It also needs @gpakosz I want to have |
Will take a look in the morning. The failing tests in CI are unrelated. |
Merged into master. |
Thank you for releasing 1.9.0.rc1 and I successfully installed it!
|
This PR makes it so the call to
libxml2
'sconfigure
script is done with passingRANLIB=/usr/bin/ranlib
when running on Darwin.This makes building native extensions more robust to the target system in the following situation:
PATH
/usr/local/bin
In particular, having
libxml2
build call GNU'sranlib
instead of Darwin'sranlib
fails building native extensions with very cryptic error messages. The root cause is far from being obvious and one can waste many hours on it.As such, I suggest trying to spare users and maintainers' time (less issues opened) by helping
libxml2
's build system a bit.