Use the :encoding arg on Document.parse even when contents are blank #1043
+19
−5
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently,
Nokogiri::XML::Document.parse
andNokogiri::HTML::Document.parse
discards theencoding
argument if it receivesnil
orblank
contents for thestring_or_io
argument. This pull tweaks the code to set theencoding
value (if it is passed in) even when thestring_or_io
argument is blank.This is really just a convenience thing, so that if you want to compose a blank document with an particular encoding, you can do something like this:
instead of having to do something like this:
This is particularly helpful for Ruby18 users where the
String
class does not have the concept of encoding on it's own. True, you can technically condense the above example down into this:But it's cleaner to just have the
parse
method enforce the encoding regardless of contents it receives.