Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

System font greater than 13pt for SUStatus.xib #2613

Closed
ChrisW698 opened this issue Aug 23, 2024 · 4 comments · Fixed by #2614
Closed

System font greater than 13pt for SUStatus.xib #2613

ChrisW698 opened this issue Aug 23, 2024 · 4 comments · Fixed by #2614

Comments

@ChrisW698
Copy link

We’ve received a number of user reports concerning the Sparkle update progress dialog, where the ‘x MB of x MB’ text appears larger than the System Regular 13 font size, causing the download progress count to be truncated. As shown in the attached screenshot, it seems that users are increasing the system-wide font size beyond System Regular 13 using TinkerTool, which is leading to this issue.
Sparkle-TechToolPro

@zorgiepoo
Copy link
Member

zorgiepoo commented Aug 23, 2024

This is an annoying Autolayout issue to enforce that the text field makes the window grow horizontally instead of wrapping or truncating in SUStatus.xib (SUStatusController also sets the font for the text field to be a monospaced digit system font with system font size).

After changing the system font you can set a breakpoint in -[SPUStandardUserDriver showDownloadDidStartExtractingUpdate:] to see how the status window looks like.

Note changing the system font with a non-system tool like TinkerTool is not a super supported/common path. However increasing the text field font size should technically work. Maybe @DivineDominion would have an idea on this. I don't want to subclass NSTextField.

@zorgiepoo
Copy link
Member

Actually have a fix in #2614

@ChrisW698
Copy link
Author

Thank you and greatly appreciated.

@DivineDominion
Copy link
Contributor

@zorgiepoo I'm not that fast :D Happy that you found a solution already!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants