Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a check for multiple stories before rendering the the Stories component in the DocsPage. #2494

Closed
ssabo1 opened this issue Dec 31, 2019 · 0 comments
Assignees
Labels
Pull Ahead Sprint Pull Ahead Issue

Comments

@ssabo1
Copy link
Collaborator

ssabo1 commented Dec 31, 2019

User Story:
In researching #2385, I couldn't replicate the issue anymore. In talking with @yodasw16, I mentioned another issue that I discovered while researching this thats similar to this one. Dave gave me the permission to submit a PR onto storybook to fix it and said to work with @ssabo1 to create an issue for it when she gets back into office. The issue and the details of the problem are here. storybookjs/storybook#9268

AC:

  • Added a check for multiple stories before rendering the the Stories component in the DocsPage. Without this check, unnecessary rendering of the Stories component headline would occur.
@ssabo1 ssabo1 added this to the 12.30.19-1.10.20 milestone Dec 31, 2019
@ssabo1 ssabo1 added the Pull Ahead Sprint Pull Ahead Issue label Dec 31, 2019
@ssabo1 ssabo1 closed this as completed Dec 31, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Pull Ahead Sprint Pull Ahead Issue
Projects
None yet
Development

No branches or pull requests

2 participants