New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

USB Serial might deadlock when interrupts are masked #1186

Merged

avtolstoy merged 2 commits into develop from feature/fix-usb-serial-deadlock-masked-interrupts

Nov 29, 2016

Member

avtolstoy commented Nov 29, 2016 •

edited by technobly

Loading

Appears only when logging on Serial is enabled and DEBUG_BUILD=y. Introduced by d81371e from PR #1127

Tests: wiring/usbserial/usbserial.cpp

Doneness:

Contributor has signed CLA
Problem and Solution clearly stated
Code peer reviewed
API tests compiled
Run unit/integration/application tests on device
Add documentation (N/A)
Add to CHANGELOG.md after merging (add links to docs and issues)

Bugfix

Fixed issue where USB Serial might deadlock when interrupts are disabled while using DEBUG_BUILD=y.

avtolstoy added 2 commits

November 29, 2016 23:12


          HAL_USB_WillPreempt should return false when interrupts are masked

21a2704


          Test USBSERIAL_01_SerialDoesNotDeadlockWhenInterruptsAreMasked added1

7d10df8

m-mcgowan approved these changes

View reviewed changes

avtolstoy merged commit 47e45de into develop

technobly deleted the feature/fix-usb-serial-deadlock-masked-interrupts branch

November 29, 2016 19:15

technobly added this to the 0.6.1 milestone

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet