Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix for subscriptions checksum calculation #1130

Merged
merged 1 commit into from
Sep 30, 2016

Conversation

sergeuz
Copy link
Member

@sergeuz sergeuz commented Sep 30, 2016

handler.scope is an enum, and we want its address to be casted to uint8_t*, not its value


Doneness:

  • Contributor has signed CLA
  • Problem and Solution clearly stated
  • Code peer reviewed
  • API tests compiled
  • Run unit/integration/application tests on device
  • Add documentation (N/A)
  • Add to CHANGELOG.md after merging (add links to docs and issues)

BUGFIX

  • Particle.subscribe() used with same events but changing scope between PUBLIC and PRIVATE or vice versa would potentially result in non-registered subscriptions. This was also crashing the GCC virtual device with a segfault when subscription checksums were calculated.

Copy link
Member

@technobly technobly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks easy enough but I want to understand what this impacts. What is the current issue, is it something that affects users and how will this alter it?

Copy link
Member

@technobly technobly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After adding a BUGFIX note, changes are approved :)

@technobly technobly added the bug label Sep 30, 2016
@technobly technobly added this to the 0.7.x milestone Sep 30, 2016
@monkbroc
Copy link
Member

This also crashed the virtual device with a segfault

@technobly
Copy link
Member

Thanks, I added that to the bugfix note.

@sergeuz sergeuz merged commit d621a96 into develop Sep 30, 2016
@technobly technobly deleted the fix/gcc_platform_handshake branch September 30, 2016 19:27
@technobly technobly modified the milestones: 0.7.x, 0.6.1 Nov 29, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants