I2C improvements #1047
Merged
I2C improvements #1047
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Additional flag check after EVENT_TIMEOUT - Correct handling of NACK after sending address in HAL_I2C_End_Transmission (write) - First data byte should be loaded in DR before checking BTF flag in HAL_I2C_End_Transmission - I2C_FLAG_BTF should be used in place of I2C_EVENT_MASTER_BYTE_TRANSMITTING while transmitting bytes in HAL_I2C_End_Transmission
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Slightly connected with #1042. The issue described in #1042 was mainly caused (after removal of
SINGLE_THREADED_SECTIONfrom wiring i2c functions) by non-monotonic millis()/micros() behavior that was fixed in PR #943, which isn't in 0.5.1. While debugging that, several other non-critical issues were found in I2C HAL.Doneness: