Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Github Actions Setup for Optional Dependencies #215

Open
ardasener opened this issue Oct 25, 2022 · 0 comments · Fixed by #223
Open

Add Github Actions Setup for Optional Dependencies #215

ardasener opened this issue Oct 25, 2022 · 0 comments · Fixed by #223
Assignees
@ardasener
Labels
state: inactive Issue is abandoned, but might become relavent at some point type: chore Converting measurements, reorganizing folder structure, and other necessary (less impactful) tasks

Comments

@ardasener
Copy link
Contributor

Our current GitHub Actions setup is not testing the optional dependencies we have. The current plan is to create a separate workflow that downloads and installs the dependencies. This workflow will then build and test the library as in the current workflows. Since these dependencies are not 100% in our control (their repositories may go down or change), my suggestion is to make this workflow generate warnings (like the current lint job of the Testing workflow) and not block the merge.
@ardasener ardasener self-assigned this Oct 25, 2022
@AmroAlJundi AmroAlJundi added type: chore Converting measurements, reorganizing folder structure, and other necessary (less impactful) tasks state: inactive Issue is abandoned, but might become relavent at some point labels Oct 28, 2022
@ardasener ardasener linked a pull request Nov 1, 2022 that will close this issue
GitHub Action for optional dependencies #223
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ardasener ardasener

Labels
state: inactive Issue is abandoned, but might become relavent at some point type: chore Converting measurements, reorganizing folder structure, and other necessary (less impactful) tasks
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

GitHub Action for optional dependencies sparcityeu/SparseBase
2 participants
@AmroAlJundi @ardasener