re-enable no-var rule and autofix violations

.eslintrc

@@ -2,7 +2,6 @@
 extends: '@elastic/kibana'
 rules:
   no-unused-vars: off
-  no-var: off
   prefer-const: off
   no-extra-semi: off
   quotes: off

src/core_plugins/kibana/public/management/sections/indices/add_data_steps/pipeline_setup/lib/keys_deep.js

@@ -5,7 +5,7 @@ export default function keysDeep(object, base) {
   let delimitedBase = base ? base + '.' : '';
 
   _.forEach(object, (value, key) => {
-    var fullKey = delimitedBase + key;
+    let fullKey = delimitedBase + key;
     if (_.isPlainObject(value)) {
       result = result.concat(keysDeep(value, fullKey));
     } else {

src/core_plugins/kibana/public/management/sections/indices/filebeat/directives/filebeat_wizard.js

@@ -20,11 +20,11 @@ modules.get('apps/management')
       const ingest = Private(IngestProvider);
       const $state = this.state = new AppState();
 
-      var notify = new Notifier({
+      let notify = new Notifier({
         location: 'Add Data'
       });
 
-      var totalSteps = 4;
+      let totalSteps = 4;
       this.stepResults = {};
 
       this.setCurrentStep = (step) => {

src/core_plugins/kibana/public/management/sections/indices/upload/directives/upload_wizard.js

@@ -19,11 +19,11 @@ modules.get('apps/management')
         const ingest = Private(IngestProvider);
         const $state = this.state = new AppState();
 
-        var notify = new Notifier({
+        let notify = new Notifier({
           location: 'Add Data'
         });
 
-        var totalSteps = 3;
+        let totalSteps = 3;
         this.stepResults = {};
 
         this.setCurrentStep = (step) => {

src/core_plugins/table_vis/public/table_vis_controller.js

@@ -11,7 +11,7 @@ const module = uiModules.get('kibana/table_vis', ['kibana']);
 module.controller('KbnTableVisController', function ($scope, Private) {
   const tabifyAggResponse = Private(AggResponseTabifyTabifyProvider);
 
-  var uiStateSort = ($scope.uiState) ? $scope.uiState.get('vis.params.sort') : {};
+  let uiStateSort = ($scope.uiState) ? $scope.uiState.get('vis.params.sort') : {};
   assign($scope.vis.params.sort, uiStateSort);
 
   $scope.sort = $scope.vis.params.sort;

src/fixtures/mock_ui_state.js

@@ -10,4 +10,4 @@ export default {
   },
   on: _.noop,
   off: _.noop
-}
+};

src/ui/public/directives/__tests__/paginated_selectable_list.js

@@ -21,9 +21,9 @@ let stringList = [
 
 let lists = [objectList, stringList, []];
 
-var $scope;
-var $element;
-var $isolatedScope;
+let $scope;
+let $element;
+let $isolatedScope;
 
 lists.forEach(function (list) {
   let isArrayOfObjects = list.every((item) => {

src/ui/public/kbn_top_nav/__tests__/kbn_top_nav_controller.js

@@ -303,7 +303,7 @@ describe('KbnTopNavController', function () {
         expect(controller.menuItems).to.have.length(4);
 
         // check that the items were added
-        var matches = controller.menuItems.reduce((acc, item) => {
+        let matches = controller.menuItems.reduce((acc, item) => {
           if (item.key === 'green' || item.key === 'red') {
             acc[item.key] = item;
           }
@@ -324,7 +324,7 @@ describe('KbnTopNavController', function () {
         expect(controller.menuItems).to.have.length(3);
 
         // check that the items were added
-        var match = controller.menuItems.filter((item) => {
+        let match = controller.menuItems.filter((item) => {
           return item.key === 'green';
         });
         expect(match[0]).to.have.property('run');

src/ui/public/paginated_table/__tests__/index.js

@@ -165,7 +165,7 @@ describe('paginated table', function () {
       paginatedTable.sortColumn(1);
       $scope.$digest();
 
-      var tableRows = $el.find('tbody tr');
+      let tableRows = $el.find('tbody tr');
       expect(tableRows.eq(2).find('td').eq(1).text()).to.be('cccc');
       expect(tableRows.eq(1).find('td').eq(1).text()).to.be('bbbb');
       expect(tableRows.eq(0).find('td').eq(1).text()).to.be('aaaa');
@@ -175,7 +175,7 @@ describe('paginated table', function () {
       paginatedTable.sortColumn(1, 'desc');
       $scope.$digest();
 
-      var tableRows = $el.find('tbody tr');
+      let tableRows = $el.find('tbody tr');
       expect(tableRows.eq(0).find('td').eq(1).text()).to.be('zzzz');
       expect(tableRows.eq(1).find('td').eq(1).text()).to.be('cccc');
       expect(tableRows.eq(2).find('td').eq(1).text()).to.be('bbbb');

src/ui/public/pattern_checker/pattern_checker.js

@@ -17,7 +17,7 @@ module.directive('patternChecker', function () {
     controller: function (Notifier, $scope, $timeout, $http) {
       let validationTimeout;
 
-      var notify = new Notifier({
+      let notify = new Notifier({
         location: 'Add Data'
       });
 

src/ui/public/vislib/__tests__/lib/layout/splits/column_chart/splits.js

@@ -173,9 +173,9 @@ describe('Vislib Split Function Test Suite', function () {
     });
 
     describe('chart title split function', function () {
-      var visEl;
-      var newEl;
-      var fixture;
+      let visEl;
+      let newEl;
+      let fixture;
 
       beforeEach(ngMock.inject(function () {
         visEl = el.append('div').attr('class', 'vis-wrapper');

tasks/build/babel_options.js

@@ -1,9 +1,9 @@
 module.exports = function (grunt) {
 
-  var srcFile = 'build/kibana/src/optimize/babel_options.js';
-  var buildFile = 'build/kibana/src/optimize/babel_options.build.js';
-  var rename = require('fs').renameSync;
-  var unlink = require('fs').unlinkSync;
+  let srcFile = 'build/kibana/src/optimize/babel_options.js';
+  let buildFile = 'build/kibana/src/optimize/babel_options.build.js';
+  let rename = require('fs').renameSync;
+  let unlink = require('fs').unlinkSync;
 
   grunt.registerTask('_build:babelOptions', function () {
     unlink(srcFile);

tasks/build/download_node_builds.js

@@ -65,8 +65,8 @@ module.exports = function (grunt) {
 
     activeDownloads.push(platform);
 
-    var bytes = parseInt(resp.headers['content-length'], 10) || 'unknown number of';
-    var mb = ((bytes / 1024) / 1024).toFixed(2);
+    let bytes = parseInt(resp.headers['content-length'], 10) || 'unknown number of';
+    let mb = ((bytes / 1024) / 1024).toFixed(2);
     grunt.log.ok(`downloading ${platform.name} - ${mb} mb`);
   };
 

tasks/build/install_npm_deps.js

@@ -1,6 +1,6 @@
 module.exports = function (grunt) {
-  var { exec } = require('child_process');
-  var { resolve } = require('path');
+  let { exec } = require('child_process');
+  let { resolve } = require('path');
 
   grunt.registerTask('_build:installNpmDeps', function () {
     grunt.file.mkdir('build/kibana/node_modules');

tasks/build/shasums.js

@@ -1,12 +1,12 @@
-var { promisify } = require('bluebird');
-var readdir = promisify(require('fs').readdir);
-var exec = promisify(require('child_process').exec);
-var platform = require('os').platform();
-var cmd = /^win/.test(platform) ? 'sha1sum ' : 'shasum ';
+let { promisify } = require('bluebird');
+let readdir = promisify(require('fs').readdir);
+let exec = promisify(require('child_process').exec);
+let platform = require('os').platform();
+let cmd = /^win/.test(platform) ? 'sha1sum ' : 'shasum ';
 
 module.exports = function (grunt) {
   grunt.registerTask('_build:shasums', function () {
-    var targetDir = grunt.config.get('target');
+    let targetDir = grunt.config.get('target');
 
     // for when shasums is run but archives and ospackages was not
     grunt.file.mkdir(targetDir);

tasks/config/eslint.js

@@ -1,4 +1,4 @@
-var resolve = require('path').resolve;
+let resolve = require('path').resolve;
 
 module.exports = function (grunt) {
   return {

tasks/config/esvm.js

@@ -1,8 +1,8 @@
 module.exports = function (grunt) {
-  var resolve = require('path').resolve;
-  var directory = resolve(__dirname, '../../esvm');
-  var dataDir = resolve(directory, 'data_dir');
-  var serverConfig = require('../../test/server_config');
+  let resolve = require('path').resolve;
+  let directory = resolve(__dirname, '../../esvm');
+  let dataDir = resolve(directory, 'data_dir');
+  let serverConfig = require('../../test/server_config');
 
   return {
     options: {

tasks/config/intern.js

@@ -1,4 +1,4 @@
-var path = require('path');
+let path = require('path');
 
 
 module.exports = function (grunt) {

tasks/config/s3.js

@@ -1,5 +1,5 @@
 module.exports = function (grunt) {
-  var { config } = grunt;
+  let { config } = grunt;
 
   return {
     release: {

tasks/lint_staged_files.js

@@ -8,7 +8,7 @@ export default function (grunt) {
     grunt.task.requires('collectFilesToCommit');
 
     // match these patterns
-    var patterns = grunt.config.get('eslint.source.files.src');
+    let patterns = grunt.config.get('eslint.source.files.src');
     if (!patterns) grunt.fail.warn('eslint file pattern is not defined');
 
     const files = grunt.config

tasks/release_packages.js

@@ -59,7 +59,7 @@ export default (grunt) => {
       grunt.fail.fatal('Aborting publish');
     }
 
-    var rl = readline.createInterface({
+    let rl = readline.createInterface({
       input: process.stdin,
       output: process.stdout
     });

tasks/sterilize.js

@@ -26,7 +26,7 @@ export default function (grunt) {
 
     rl.on('close', this.async());
     rl.question(`\n${danger} Do you really want to delete all of the above files?, [N/y] `, function (resp) {
-      var yes = resp.toLowerCase().trim()[0] === 'y';
+      let yes = resp.toLowerCase().trim()[0] === 'y';
       rl.close();
 
       if (yes) {

tasks/utils/install_or_update_repo.js

@@ -1,12 +1,12 @@
-var Promise = require('bluebird');
-var spawn = require('./spawn');
-var grunt = require('grunt');
+let Promise = require('bluebird');
+let spawn = require('./spawn');
+let grunt = require('grunt');
 
 module.exports = function (repo, dir) {
   // store the previous and new hash from the repo
   // to know if there was an update from fetch
-  var prevHash;
-  var newHash;
+  let prevHash;
+  let newHash;
 
   return Promise.resolve()
   .then(function () {

tasks/utils/update_version.js

@@ -1,8 +1,8 @@
-var _ = require('lodash');
+let _ = require('lodash');
 
 module.exports = updateVersion;
 
-var versions = [
+let versions = [
   'major',
   'minor',
   'patch',
@@ -44,7 +44,7 @@ var versions = [
 function updateVersion(version, expr) {
   expr = String(expr).split('=');
 
-  var change = {
+  let change = {
     name: expr[0],
     val: expr[1] || null
   };
@@ -58,7 +58,7 @@ function updateVersion(version, expr) {
   }
 
   // parse the current version
-  var parts = _.chain(version.split('.'))
+  let parts = _.chain(version.split('.'))
 
   // ensure that their are three pieces, either x.x.x or x.x.x-y
   .tap(function (versionNumbers) {
@@ -70,7 +70,7 @@ function updateVersion(version, expr) {
   // describe all of the version parts with a name, parse
   // the numbers, and extract tag from patch
   .transform(function (parts, v, i) {
-    var name = versions[i];
+    let name = versions[i];
 
     if (name !== 'patch') {
       parts[name] = _.parseInt(v);
@@ -86,7 +86,7 @@ function updateVersion(version, expr) {
   // sanity check
   .tap(function (parts) {
 
-    var valid = true;
+    let valid = true;
     valid = valid && _.isNumber(parts.major);
     valid = valid && _.isNumber(parts.minor);
     valid = valid && _.isNumber(parts.patch);
@@ -121,7 +121,7 @@ function updateVersion(version, expr) {
     }
 
     // properties that are zero-d by the previous update
-    var emptyUpdates = versions.slice(versions.indexOf(change.name) + 1);
+    let emptyUpdates = versions.slice(versions.indexOf(change.name) + 1);
     while (emptyUpdates.length) {
       parts[emptyUpdates.shift()] = '';
     }