Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes issue 128 #129

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Fixes issue 128 #129

wants to merge 2 commits into from

Conversation

rosteen
Copy link

@rosteen rosteen commented Mar 6, 2020

Updated the to_griddedpsfmodel call to match the current webbpfs version.

EDIT: Fix #128

@pllim
Copy link
Contributor

pllim commented Mar 6, 2020

Thanks! Probably want to update the requirements.txt to bump the min version too.

@rosteen
Copy link
Author

rosteen commented Mar 6, 2020

Thanks! Probably want to update the requirements.txt to bump the min version too.

Good call, just committed that update

@pllim
Copy link
Contributor

pllim commented Mar 11, 2020

The green status might be misleading. When I look at the logs, it reports errors but I don't know how to interpret them. I'll leave this to @eteq or @jbcurtin .

@jbcurtin
Copy link
Contributor

hey @pllim , yeah, I'm working through most errors now in jbcurtin/spacetelescope. The build log is a little miss leading right now, I'm working towards fixing that too

@eteq
Copy link
Collaborator

eteq commented Mar 31, 2020

@rosteen - just to confirm here - you did run the notebook with the versions stated in the requirements file, right? If so I think it's probably fine to merge this even with the CI issues outstanding since this fix is desirable in the notebook itself anyway.

@rosteen
Copy link
Author

rosteen commented Mar 31, 2020

@eteq If I'm remembering correctly, I tried it in a clean env with everything installed by feeding pip the requirements file.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Outdated function call in PSF_phot_01 throwing error in notebook
4 participants