-
Notifications
You must be signed in to change notification settings - Fork 164
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes issue 128 #129
base: master
Are you sure you want to change the base?
Fixes issue 128 #129
Conversation
Thanks! Probably want to update the |
Good call, just committed that update |
hey @pllim , yeah, I'm working through most errors now in |
@rosteen - just to confirm here - you did run the notebook with the versions stated in the requirements file, right? If so I think it's probably fine to merge this even with the CI issues outstanding since this fix is desirable in the notebook itself anyway. |
@eteq If I'm remembering correctly, I tried it in a clean env with everything installed by feeding pip the requirements file. |
Updated the
to_griddedpsfmodel
call to match the current webbpfs version.EDIT: Fix #128