Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Photometric Extraction plugin #115

Draft
wants to merge 12 commits into
base: main
Choose a base branch
from

Conversation

kecnry
Copy link
Member

@kecnry kecnry commented Apr 22, 2024

Work in progress - photometric extraction from TPF data cubes.

UI is improved by spacetelescope/jdaviz#3227 but is not yet technically needed to be pinned here. Although without it, there is a warning shown in the UI about unit conflicts.

rendered plugin docs

Screen.Recording.2024-10-18.at.9.27.15.AM.mov

TODO:

  • implement API hints
  • restrict function to only allow sum
  • coerce TPF cubes into /pix2
  • skip spatial subsets in plot options and legends for scatter viewer (make sure that reset zoom is still correct)
  • fix previews (should show in all scatter viewers? or just those selected for export?)
  • test coverage
  • update API docs
  • update docs
  • investigate/fix subset preview for a rectangle not aligning with mask - might be upstream bug that also affects cubeviz, or could be correct and just more obvious for large pixels

Follow-up efforts:

  • label flux column based on the plugin/subset (applies to other plugins as well)
  • default subset when loading in TPF or on demand from subset tools?
  • does stitch need to be smarter to exclude entries on same time scale? Or maybe to exclude products from plugins (except for flattening which changes flux col anyways)?
  • per-pixel subset tool
  • tutorial on lcviz-demos

Waiting for: jdaviz 4.0 spacetelescope/jdaviz#2939 to be merged, released, pinned

@kecnry kecnry added this to the 0.4.0 milestone Apr 22, 2024
@kecnry kecnry added trivial no review required and removed trivial no review required labels Apr 22, 2024
@kecnry kecnry force-pushed the photometric-extraction branch from cdd09b9 to 5f8a65e Compare May 29, 2024 16:58
@kecnry kecnry force-pushed the photometric-extraction branch from c8d2496 to b7fe196 Compare June 13, 2024 07:16
@kecnry kecnry force-pushed the photometric-extraction branch from b7fe196 to e8c9be9 Compare June 26, 2024 15:55
@kecnry kecnry modified the milestones: 0.4.0, 0.5.0 Jun 26, 2024
@kecnry kecnry force-pushed the photometric-extraction branch from 4efd5d5 to 1fc3fb5 Compare July 12, 2024 17:37
@kecnry kecnry added the waiting-on-jdaviz-release PR requires a release from jdaviz before updating the pin label Jul 12, 2024
@kecnry kecnry force-pushed the photometric-extraction branch from 976e6d6 to 05c4f04 Compare July 12, 2024 19:28
Copy link

codecov bot commented Jul 12, 2024

Codecov Report

Attention: Patch coverage is 87.23404% with 6 lines in your changes missing coverage. Please review.

Project coverage is 91.06%. Comparing base (7b78df5) to head (fa0d087).
Report is 25 commits behind head on main.

Files Patch % Lines
...s/photometric_extraction/photometric_extraction.py 86.04% 6 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #115      +/-   ##
==========================================
- Coverage   93.92%   91.06%   -2.87%     
==========================================
  Files          37       43       +6     
  Lines        1598     2104     +506     
==========================================
+ Hits         1501     1916     +415     
- Misses         97      188      +91     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kecnry kecnry force-pushed the photometric-extraction branch 2 times, most recently from da6bc3e to a09691f Compare August 21, 2024 14:18
@kecnry kecnry removed the waiting-on-jdaviz-release PR requires a release from jdaviz before updating the pin label Oct 17, 2024
@kecnry kecnry force-pushed the photometric-extraction branch from a09691f to 28a4cff Compare October 17, 2024 16:36
@kecnry kecnry force-pushed the photometric-extraction branch from 28a4cff to fae2324 Compare October 17, 2024 18:39
* dropdown will still show until future PR to upstream
@kecnry kecnry modified the milestones: 1.0.0, 1.1.0 Dec 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant