You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
While fixing #3307 I realized that we're not handling masks correctly at the moment for cubes. When we load a data cube, if it has a mask attribute that gets split out into a separate mask cube. Currently, that input mask is not being respected when we do a spectral extraction on the flux cube, leading to potentially incorrect extraction results and buggy behavior downstream when trying to, e.g., fit a model to the extracted spectrum. We need to handle input masks properly and apply them to both the flux and uncertainty cubes when extracting.
How to Reproduce
Load a MaNGA cube, attempt to fit a model to the full cube extracted spectrum, see that it fails (because all uncertainties are non-finite).
Expected behavior
No response
Browser
No response
Jupyter
No response
Software versions
No response
The text was updated successfully, but these errors were encountered:
Jdaviz component
Cubeviz
Description
While fixing #3307 I realized that we're not handling masks correctly at the moment for cubes. When we load a data cube, if it has a mask attribute that gets split out into a separate mask cube. Currently, that input mask is not being respected when we do a spectral extraction on the flux cube, leading to potentially incorrect extraction results and buggy behavior downstream when trying to, e.g., fit a model to the extracted spectrum. We need to handle input masks properly and apply them to both the flux and uncertainty cubes when extracting.
How to Reproduce
Load a MaNGA cube, attempt to fit a model to the full cube extracted spectrum, see that it fails (because all uncertainties are non-finite).
Expected behavior
No response
Browser
No response
Jupyter
No response
Software versions
No response
The text was updated successfully, but these errors were encountered: