Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Recenter tool only looks at reference layer #2265

Closed
Jdaviz-Triage-Bot opened this issue Jun 26, 2023 · 2 comments · Fixed by #2154
Closed

Recenter tool only looks at reference layer #2265

Jdaviz-Triage-Bot opened this issue Jun 26, 2023 · 2 comments · Fixed by #2154
Labels
bug Something isn't working imviz

Comments

@Jdaviz-Triage-Bot
Copy link

Jdaviz-Triage-Bot commented Jun 26, 2023

Reporter: Camilla Pacifici

  1. I have 2 images loaded with different resolutions (e.g., same object in at pixel 300,500 in image 1 and at pixel 30,50 in image 2).
  2. I select a subset. Subset tool says the subset is at 300,500.
  3. If I select image 1 and I use the recenter tool, it works fine.
  4. If I select image 2 and I use the recenter tool, it tries to recenter on pixel 300,500 instead of at 30,50 and starts wondering around. The user has no ides what is happening.

Need to figure out a way to deal with this.

As a user, in an ideal world, I would expect the subset to automatically shift to the correct position in image 2, but this might get cumbersome if the user keeps switching from one to the other.
Working in sky coordinates might solve the problem, but the pixel position would still need to be obvious to the user.

Any mitigation plans in the meantime are welcome.

🐱


DISCLAIMER: This issue was autocreated by the Jdaviz Issue Creation Bot on behalf of the reporter. If any information is incorrect, please contact Duy Nguyen

@pllim pllim added bug Something isn't working imviz labels Jun 26, 2023
@camipacifici
Copy link
Contributor

In the example, images are linked by WCS.

@pllim
Copy link
Contributor

pllim commented Jun 26, 2023

The user has no ides what is happening.

I think what is happening is the same problem as #2139 . The center is accounted for correctly but not the different pixel scales. So, the circle becomes too big when you apply it to the second smaller image. As a result, you probably get too much junk data in that aperture, breaking centering feature.

A natural way to fix this is to use sky region behind the scenes (as discussed also for other workflow problems).

However, this also naturally becomes a non-issue if we proceed with #2238

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working imviz
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants