BUG: Ellipse translation in app.get_subsets() is wrong

[pllim]

jdaviz/jdaviz/app.py

Line 1009 in 7ffaa26

roi_as_region = EllipsePixelRegion(PixCoord(xc, yc), rx, ry, Angle(theta, "deg"))

is wrong because glue defines radius while regions defines width and height. Really, we should be using the translators already vetted and in place here: https://github.com/glue-viz/glue-astronomy/blob/main/glue_astronomy/translators/regions.py

The complication is that to use the upstream translator directly the way we do the translation in this method, we also need to modify upstream.

I already have the fixes but I open an issue anyway so users are aware, because this bug is very subtle. Fixes here:

• FEAT: Support sky regions and allow direct call to translator function glue-viz/glue-astronomy#93
• FEAT: Annulus draw tool for Imviz #2240

🐱