You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
As proposed by @kecnry , here is the desired workflow:
User select new shape tool from the existing shapes drop-down.
User click and drag to draw. At this point, it is basically the circle draw tool.
When finalized, this tool magically creates an annulus shape with hardcoded width (proposed: inner_radius = outer_radius * 0.5).
To modify the annulus shape, user has to edit it manually in the Subset Tools plugin.
New features to be implemented:
a. A new shape tool that subclass the circular shape but then turns it into annulus when finalized.
b. Subset Tools plugin needs special logic so that user can edit only the following for annulus (which is a very special case of compound subset): One center, inner radius, outer radius. @javerbukh proposed maybe we can subclass subset state or attach metadata to the state.
Under the hood:
Annulus subset state
|___ ROI state --> CircularROI
|___ Invert state --> ROI state --> Circular ROI
DISCLAIMER: This issue was autocreated by the Jdaviz Issue Creation Bot on behalf of the reporter. If any information is incorrect, please contact Duy Nguyen
The text was updated successfully, but these errors were encountered:
Reporter: pllim
As proposed by @kecnry , here is the desired workflow:
inner_radius = outer_radius * 0.5
).New features to be implemented:
a. A new shape tool that subclass the circular shape but then turns it into annulus when finalized.
b. Subset Tools plugin needs special logic so that user can edit only the following for annulus (which is a very special case of compound subset): One center, inner radius, outer radius. @javerbukh proposed maybe we can subclass subset state or attach metadata to the state.
Under the hood:
where
and
and
Also see https://github.com/glue-viz/glue-astronomy/blob/336e2cca4a93025e34e4a0d4313b4031f2f794dc/glue_astronomy/translators/regions.py#L52
This needs new glue-astronomy release upstream (>0.7).
🐱
DISCLAIMER: This issue was autocreated by the Jdaviz Issue Creation Bot on behalf of the reporter. If any information is incorrect, please contact Duy Nguyen
The text was updated successfully, but these errors were encountered: