Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NIRISS Parser does not assign rows in metadata of spec 1ds #1805

Closed
Jdaviz-Triage-Bot opened this issue Nov 1, 2022 · 0 comments · Fixed by #1836
Closed

NIRISS Parser does not assign rows in metadata of spec 1ds #1805

Jdaviz-Triage-Bot opened this issue Nov 1, 2022 · 0 comments · Fixed by #1836
Labels
bug Something isn't working mosviz

Comments

@Jdaviz-Triage-Bot
Copy link

Reporter: Duy Nguyen

Discovered in [https://github.com//pull/1798]

When loading our NIRISS example data, the NIRISS parser only assigns row numbers to the 2D spectra. Row numbers are needed for the data dropdown filtering logic to work properly; otherwise, it falls onto the fallback, which was enhanced in 1798.


for di in mosviz.app.state.data_items:
    print(f"\{di['name']} row=\{di['meta'].get('mosviz_row')}")

currently returns row=None for the 1D spectra


DISCLAIMER: This issue was autocreated by the Jdaviz Issue Creation Bot on behalf of the reporter. If any information is incorrect, please contact Duy Nguyen

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working mosviz
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants