You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Image viewers across Jdaviz, namely, Cubeviz, Imviz, and Specviz2d, have coordinates info panel but with slight variations to handle different needs. They all share the same plugin:
However, the calls to that plugin in the individual viewers were implemented differently. Most of the code were duplicated with variations. @kecnry said there is a need for a refactor so all viewers can use the same code (e.g., inherit from some mixin class).
Keep in mind that all the vizes have slightly different use cases:
Imviz (original implementation): 2D images that can be dithered but linked by WCS. It needs to support any number of arbitrary 2D images setup (some can have WCS, some not, and they can be each linked differently back to reference data in the same session).
Cubeviz: Primary data shown is a slice of 3D cube. But the panel must also be able to handle generated 2D products like moment maps.
Specviz2d: Data is 2D but it is 2D spectrum that may or may not have WCS. Currently sky coordinates are not supported. Not very sure what variations of use cases we need to support here.
DISCLAIMER: This issue was autocreated by the Jdaviz Issue Creation Bot on behalf of the reporter. If any information is incorrect, please contact Duy Nguyen
The text was updated successfully, but these errors were encountered:
Reporter: pllim
Image viewers across Jdaviz, namely, Cubeviz, Imviz, and Specviz2d, have coordinates info panel but with slight variations to handle different needs. They all share the same plugin:
https://github.com/spacetelescope/jdaviz/tree/main/jdaviz/configs/imviz/plugins/coords_info
However, the calls to that plugin in the individual viewers were implemented differently. Most of the code were duplicated with variations. @kecnry said there is a need for a refactor so all viewers can use the same code (e.g., inherit from some mixin class).
Keep in mind that all the vizes have slightly different use cases:
🐱
DISCLAIMER: This issue was autocreated by the Jdaviz Issue Creation Bot on behalf of the reporter. If any information is incorrect, please contact Duy Nguyen
The text was updated successfully, but these errors were encountered: