From cc31e7e38e9c210f3157485c195cc877b27f1502 Mon Sep 17 00:00:00 2001
From: Duy Nguyen <duytnguyendtn.open@gmail.com>
Date: Thu, 22 Sep 2022 17:12:33 -0400
Subject: [PATCH] Attach select menus

---
 jdaviz/components/plugin_dataset_select.vue                  | 1 +
 jdaviz/components/plugin_layer_select.vue                    | 1 +
 jdaviz/components/plugin_subset_select.vue                   | 1 +
 jdaviz/components/plugin_viewer_select.vue                   | 1 +
 jdaviz/configs/default/plugins/collapse/collapse.vue         | 1 +
 .../default/plugins/gaussian_smooth/gaussian_smooth.vue      | 1 +
 jdaviz/configs/default/plugins/line_lists/line_lists.vue     | 2 ++
 .../configs/default/plugins/model_fitting/model_fitting.vue  | 1 +
 jdaviz/configs/default/plugins/plot_options/plot_options.vue | 5 +++++
 .../imviz/plugins/aper_phot_simple/aper_phot_simple.vue      | 1 +
 jdaviz/configs/imviz/plugins/catalogs/catalogs.vue           | 1 +
 .../imviz/plugins/line_profile_xy/line_profile_xy.vue        | 1 +
 .../configs/specviz/plugins/line_analysis/line_analysis.vue  | 1 +
 .../plugins/spectral_extraction/spectral_extraction.vue      | 4 ++++
 14 files changed, 22 insertions(+)

diff --git a/jdaviz/components/plugin_dataset_select.vue b/jdaviz/components/plugin_dataset_select.vue
index d7d6bf4612..eb9f2af9ba 100644
--- a/jdaviz/components/plugin_dataset_select.vue
+++ b/jdaviz/components/plugin_dataset_select.vue
@@ -3,6 +3,7 @@
   <v-row v-if="items.length > 1 || show_if_single_entry">
     <v-select
       :menu-props="{ left: true }"
+      attach
       :items="items"
       v-model="selected"
       @change="$emit('update:selected', $event)"
diff --git a/jdaviz/components/plugin_layer_select.vue b/jdaviz/components/plugin_layer_select.vue
index 73e075be62..e50fbbf408 100644
--- a/jdaviz/components/plugin_layer_select.vue
+++ b/jdaviz/components/plugin_layer_select.vue
@@ -3,6 +3,7 @@
   <v-row v-if="items.length > 1 || show_if_single_entry">
     <v-select
       :menu-props="{ left: true }"
+      attach
       :items="items"
       v-model="selected"
       @change="$emit('update:selected', $event)"
diff --git a/jdaviz/components/plugin_subset_select.vue b/jdaviz/components/plugin_subset_select.vue
index f7d2359d2b..f01c99c167 100644
--- a/jdaviz/components/plugin_subset_select.vue
+++ b/jdaviz/components/plugin_subset_select.vue
@@ -3,6 +3,7 @@
   <v-row v-if="items.length > 1 || show_if_single_entry">
     <v-select
       :menu-props="{ left: true }"
+      attach
       :items="items"
       v-model="selected"
       @change="$emit('update:selected', $event)"
diff --git a/jdaviz/components/plugin_viewer_select.vue b/jdaviz/components/plugin_viewer_select.vue
index 61cb83aa4e..b5309d2d1f 100644
--- a/jdaviz/components/plugin_viewer_select.vue
+++ b/jdaviz/components/plugin_viewer_select.vue
@@ -3,6 +3,7 @@
   <v-row v-if="items.length > 1 || show_if_single_entry">
     <v-select
       :menu-props="{ left: true }"
+      attach
       :items="items"
       v-model="selected"
       @change="$emit('update:selected', $event)"
diff --git a/jdaviz/configs/default/plugins/collapse/collapse.vue b/jdaviz/configs/default/plugins/collapse/collapse.vue
index e905f8c760..e715f82f26 100644
--- a/jdaviz/configs/default/plugins/collapse/collapse.vue
+++ b/jdaviz/configs/default/plugins/collapse/collapse.vue
@@ -15,6 +15,7 @@
     <v-row>
       <v-select
         :menu-props="{ left: true }"
+        attach
         :items="method_items.map(i => i.label)"
         v-model="method_selected"
         label="Method"
diff --git a/jdaviz/configs/default/plugins/gaussian_smooth/gaussian_smooth.vue b/jdaviz/configs/default/plugins/gaussian_smooth/gaussian_smooth.vue
index f49c662ff2..2d31ae5c21 100644
--- a/jdaviz/configs/default/plugins/gaussian_smooth/gaussian_smooth.vue
+++ b/jdaviz/configs/default/plugins/gaussian_smooth/gaussian_smooth.vue
@@ -17,6 +17,7 @@
       <v-row v-if="show_modes">
         <v-select
           :menu-props="{ left: true }"
+          attach
           :items="smooth_modes"
           v-model="selected_mode"
           label="Smoothing Type"
diff --git a/jdaviz/configs/default/plugins/line_lists/line_lists.vue b/jdaviz/configs/default/plugins/line_lists/line_lists.vue
index 27665ae923..51b2467157 100644
--- a/jdaviz/configs/default/plugins/line_lists/line_lists.vue
+++ b/jdaviz/configs/default/plugins/line_lists/line_lists.vue
@@ -95,6 +95,7 @@
     <v-row>
       <v-select
         :menu-props="{ left: true }"
+        attach
         :items="available_lists"
         @change="list_selected"
         label="Available Line Lists"
@@ -178,6 +179,7 @@
                 <j-tooltip tipid='plugin-line-lists-custom-unit'>
                     <v-select
                       :menu-props="{ left: true }"
+                      attach
                       :items="custom_unit_choices"
                       v-model="custom_unit"
                       label="Unit"
diff --git a/jdaviz/configs/default/plugins/model_fitting/model_fitting.vue b/jdaviz/configs/default/plugins/model_fitting/model_fitting.vue
index 9b05d8b842..e64794cb4b 100644
--- a/jdaviz/configs/default/plugins/model_fitting/model_fitting.vue
+++ b/jdaviz/configs/default/plugins/model_fitting/model_fitting.vue
@@ -35,6 +35,7 @@
     <v-form v-model="form_valid_model_component">
       <v-row v-if="model_comp_items">
         <v-select
+          attach
           :menu-props="{ left: true }"
           :items="model_comp_items.map(i => i.label)"
           v-model="model_comp_selected"
diff --git a/jdaviz/configs/default/plugins/plot_options/plot_options.vue b/jdaviz/configs/default/plugins/plot_options/plot_options.vue
index 98f21b72f6..8cd9921d77 100644
--- a/jdaviz/configs/default/plugins/plot_options/plot_options.vue
+++ b/jdaviz/configs/default/plugins/plot_options/plot_options.vue
@@ -101,6 +101,7 @@
     <glue-state-sync-wrapper v-if="config === 'cubeviz'" :sync="collapse_func_sync" :multiselect="multiselect" @unmix-state="unmix_state('function')">
       <v-select
         :menu-props="{ left: true }"
+        attach
         :items="collapse_func_sync.choices"
         v-model="collapse_func_value"
         label="Collapse Function"
@@ -157,6 +158,7 @@
     <j-plugin-section-header v-if="stretch_function_sync.in_subscribed_states">Stretch</j-plugin-section-header>
     <glue-state-sync-wrapper :sync="stretch_function_sync" :multiselect="multiselect" @unmix-state="unmix_state('stretch_function')">
       <v-select
+        attach
         :menu-props="{ left: true }"
         :items="stretch_function_sync.choices"
         v-model="stretch_function_value"
@@ -167,6 +169,7 @@
 
     <glue-state-sync-wrapper :sync="stretch_preset_sync" :multiselect="multiselect" @unmix-state="unmix_state('stretch_preset')">
       <v-select
+        attach
         :menu-props="{ left: true }"
         :items="stretch_preset_sync.choices"
         v-model="stretch_preset_value"
@@ -197,6 +200,7 @@
     <div v-if="image_visible_sync.in_subscribed_states && image_visible_value">
       <glue-state-sync-wrapper :sync="image_color_mode_sync" :multiselect="multiselect" @unmix-state="unmix_state('image_color_mode')">
         <v-select
+          attach
           :menu-props="{ left: true }"
           :items="image_color_mode_sync.choices"
           v-model="image_color_mode_value"
@@ -209,6 +213,7 @@
 
       <glue-state-sync-wrapper v-if="image_color_mode_value === 'Colormaps'" :sync="image_colormap_sync" :multiselect="multiselect" @unmix-state="unmix_state('image_colormap')">
         <v-select
+          attach
           :menu-props="{ left: true }"
           :items="image_colormap_sync.choices"
           v-model="image_colormap_value"
diff --git a/jdaviz/configs/imviz/plugins/aper_phot_simple/aper_phot_simple.vue b/jdaviz/configs/imviz/plugins/aper_phot_simple/aper_phot_simple.vue
index 699c2bc89b..e50ab34a34 100644
--- a/jdaviz/configs/imviz/plugins/aper_phot_simple/aper_phot_simple.vue
+++ b/jdaviz/configs/imviz/plugins/aper_phot_simple/aper_phot_simple.vue
@@ -103,6 +103,7 @@
         <v-row>
           <v-select
             :menu-props="{ left: true }"
+            attach
             :items="plot_types"
             v-model="current_plot_type"
             label="Plot Type"
diff --git a/jdaviz/configs/imviz/plugins/catalogs/catalogs.vue b/jdaviz/configs/imviz/plugins/catalogs/catalogs.vue
index 0ff74d1b6a..537a5fef29 100644
--- a/jdaviz/configs/imviz/plugins/catalogs/catalogs.vue
+++ b/jdaviz/configs/imviz/plugins/catalogs/catalogs.vue
@@ -15,6 +15,7 @@
      <v-row>
        <v-select
          :menu-props="{ left: true }"
+         attach
          :items="catalog_items.map(i => i.label)"
          v-model="catalog_selected"
          label="Catalog"
diff --git a/jdaviz/configs/imviz/plugins/line_profile_xy/line_profile_xy.vue b/jdaviz/configs/imviz/plugins/line_profile_xy/line_profile_xy.vue
index 7e7433a3b8..d6ce8cc433 100644
--- a/jdaviz/configs/imviz/plugins/line_profile_xy/line_profile_xy.vue
+++ b/jdaviz/configs/imviz/plugins/line_profile_xy/line_profile_xy.vue
@@ -6,6 +6,7 @@
 
     <v-row>
       <v-select
+        attach
         :menu-props="{ left: true }"
         :items="viewer_items"
         v-model="selected_viewer"
diff --git a/jdaviz/configs/specviz/plugins/line_analysis/line_analysis.vue b/jdaviz/configs/specviz/plugins/line_analysis/line_analysis.vue
index b45e2d586f..a27a4eeec6 100644
--- a/jdaviz/configs/specviz/plugins/line_analysis/line_analysis.vue
+++ b/jdaviz/configs/specviz/plugins/line_analysis/line_analysis.vue
@@ -142,6 +142,7 @@
         <v-col cols=10>
           <v-select
             :menu-props="{ left: true }"
+            attach
             :items="line_items"
             v-model="selected_line"
             label="Line"
diff --git a/jdaviz/configs/specviz2d/plugins/spectral_extraction/spectral_extraction.vue b/jdaviz/configs/specviz2d/plugins/spectral_extraction/spectral_extraction.vue
index 0b8f558078..3373c5e011 100644
--- a/jdaviz/configs/specviz2d/plugins/spectral_extraction/spectral_extraction.vue
+++ b/jdaviz/configs/specviz2d/plugins/spectral_extraction/spectral_extraction.vue
@@ -65,6 +65,7 @@
 
         <v-row>
           <v-select
+            attach
             :menu-props="{ left: true }"
             :items="trace_type_items.map(i => i.label)"
             v-model="trace_type_selected"
@@ -112,6 +113,7 @@
 
         <v-row v-if="trace_type_selected==='Auto'">
           <v-select
+            attach
             :menu-props="{ left: true }"
             :items="trace_peak_method_items.map(i => i.label)"
             v-model="trace_peak_method_selected"
@@ -170,6 +172,7 @@
 
       <v-row>
         <v-select
+          attach
           :menu-props="{ left: true }"
           :items="bg_type_items.map(i => i.label)"
           v-model="bg_type_selected"
@@ -299,6 +302,7 @@
 
       <v-row>
         <v-select
+          attach
           :menu-props="{ left: true }"
           :items="ext_type_items"
           v-model="ext_type_selected"