-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Investigate removing TEAL #1738
Comments
Comment by Matthew Burger on JIRA: Asked on slack in #python, #research, and #hst_pipeline_meeting for people to let me know if they use TEAL. Results:
|
Comment by Matthew Burger on JIRA: Chris Sontag: Awww. I wrote that a bunch of years ago. No idea who maintains it now. Thought it was dead. |
As a part of this effort, the documentation will have to be updated #1439. |
Comment by Michele De La Pena on JIRA: This issue needs some initial investigation as the underlying code which reads the default configuration files, performs type checking, and controls which parameters work in tandem with one another (i.e., turn "off" parameter one which then disables parameters six and seven as they are no longer applicable) is valuable and would potentially require a lot of re-write. Is it just the actual GUI which is not maintainable? |
Comment by Steve Goldman on JIRA: Along the line of what Michele mentioned is that the teal.teal command could be removed, while we keep the teal.load commands for the backend parsing type checking, and rules within the cfg parameter files. These would otherwise have to be converted to json, and then we would have to create new rules elsewhere in the code to compensate for the teal loads; this seems like more work than it is worth if teal.load can remain. |
Comment by Michele De La Pena on JIRA: @sgoldman |
Comment by Steve Goldman on JIRA: Thanks for the reminder! An initial attempt to remove TEAL has been created in PR 1759 more testing will be needed. In order to share this change with users, we should add documentation about the Legacy TEAL GUI, and share the change with something like a MAST newsletter or STAN. Mitchel Revalski also suggested providing a YML file or a list of the most current package versions that will work with TEAL for anyone that still wants to use the GUI. |
Comment by Michele De La Pena on JIRA: Steve Goldman Please write a ticket so we remember to notify the INS teams regarding the official deprecation of the TEAL GUI starting at version n.n.n of drizzlepac. It can be suggested they announce this in their STANs. |
Comment by Steve Goldman on JIRA: Sounds good. I know at least one package that still uses TEAL is stsci.skypac. Drizzlepac still prints out a shorter TEAL message when you import drizzlepac because stsci.skypac is a dependency. |
Issue HLA-1208 was created on JIRA by Steve Goldman:
This ticket would deprecate and then remove the TEAL interface from new versions of drizzlepac. After discussing this with Nadia, we agreed that this should be done as the current code is not maintainable.
The change would also require altering some current regression tests that use TEAL to create configuration files.
The text was updated successfully, but these errors were encountered: