-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Muxing and streams #40
Comments
We have a real api customer on the team - @IlyaVi - we should ask with him what he prefers as a wallet builder and consider his feedback. Also - per @antonlerner feedback - we should look into pub-sub vs. grpc for the api implementation framework. |
Looking into pub sub is on my to do list |
This work has been done. Results are in spacemeshos/SMIPS#13 and spacemeshos/SMIPS#21. We ended up implementing multiplexed streams in the API (see linked, merged PRs). I looked into pubsub and that conversation is ongoing in the implementation SMIP. We don't have any fancy DSL or anything for filtering now but we can look into that in future if necessary. @IlyaVi @ilans @AmitShaul please let us know if you need any changes made to the streams as defined! |
Rather than one stream per type, we may want to switch to a single master event stream that a client can subscribe to. The client can optionally pass a filter when setting up the stream if they only want to receive a subset of event types. Some advantages:
We should look into whether there's an existing specification language/DSL we can use for the filtering/stream definition.
The text was updated successfully, but these errors were encountered: