-
-
Notifications
You must be signed in to change notification settings - Fork 995
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix spacedrive://
custom protocol on Windows
#550
Conversation
(hopefully)
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 2 Ignored Deployments
|
@jamiepine this works and is ready for use. I would appreciate it if @brxken128 could give it a shot on Linux because I am concerned about if video files will work on Linux. I don't think it will stream video files on Linux and as far as I'm aware this is a Tauri limitation. It should instead, I am hoping, just load it all into memory and sends it to the webview. We could build a custom protocol to work around this limitation but that is a future concern. @james-elicx I would appreciate a test of preview media loading on Windows (although don't feel obligated to). I was unable to use the Rust code snippet you sent as it was causing issues on macOS. The system I designed converts the Right now I added a button to the right-click menu on an explorer item to test this feature. It does a full webview redirect which is something that @jamiepine is going to improve when the UI he is working on is ready. |
Looks like the protocol and thumbnails are working correctly on Windows now! I appreciate all the work you've done to fix this :) |
I've already spoken to @oscartbeaumont about this, but on Linux (Gentoo) it's a mixed bag. Thumbnails work, and opening images work, but video playback does not. It could either be a Tauri thing, or something to do with our protocol - I'm not too sure here. We're making progress though as only thumbnails worked before. |
Changes:
handle_custom_uri
function to use primitives from thehttp
crate instead of my old janky tuple. Required for steaming and is probably how I should have built this system originally.spacedrive://file/{library_id}/{location_id}/{filepath_id}
)spacedrive://file/*
proto