Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support specification of branch name in spr diff #186

Open
mingmingl-llvm opened this issue Jan 24, 2024 · 1 comment
Open

Support specification of branch name in spr diff #186

mingmingl-llvm opened this issue Jan 24, 2024 · 1 comment

Comments

@mingmingl-llvm
Copy link

It seems to me branch name is slugified from the title currently. This could give lengthy branch names. Git will create a local file(directory?) for a checked-out branch, and as a side effect, lengthy branch names gives lengthy file names. On the other hand, there is a 256-character length limit for filenames on Windows.

It'd be great to support explicit specification of branch names, like spr diff --draft --branch_name=<hand-picked-branch-name-to-ensure-no-branch-conflict>

@jrtc27
Copy link

jrtc27 commented Feb 24, 2024

Better to just have slugify truncate the title at a sane limit like 80, maybe 100, chars. 80's generally deemed normal Git convention (and 72 is when GitHub will, when opening a PR, truncate your commit title and wrap it into the PR body, so that's another option, and a common convention).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants