Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

spr list (and land) PR statuses are always PENDING #176

Open
eko-wibowo opened this issue Aug 13, 2023 · 1 comment
Open

spr list (and land) PR statuses are always PENDING #176

eko-wibowo opened this issue Aug 13, 2023 · 1 comment

Comments

@eko-wibowo
Copy link

eko-wibowo commented Aug 13, 2023

I opened pull request using spr diff, spr list / land detects the status of the PR as pending even though it's already approved. The repo is an organization repo

I cloned the repo and try to put some dbg! statements

Request

[spr/src/commands/list.rs:28] format!("repo:{}/{} is:open is:pr author:@me archived:false", config.owner,
    config.repo) = "repo:clockwisehq/services is:open is:pr author:@me archived:false"
query SearchQuery($query: String!) {
  search(query: $query, type: ISSUE, first: 100) {
    nodes {
      __typename
      ... on PullRequest {
        number
        title
        url
        reviewDecision
      }
    }
  }
}

Response

&response_body = Response {
    data: Some(
        ResponseData {
            search: SearchQuerySearch {
                nodes: Some(
                    [
                        Some(
                            PullRequest(
                                SearchQuerySearchNodesOnPullRequest {
                                    number: 5511,
                                    title: "[AI-1016] Send OOO information to Rust defrag",
                                    url: "https://github.com/<REMOVED>/services/pull/5511",
                                    review_decision: None,
                                },
                            ),
                        ),
                        Some(
                            PullRequest(
                                SearchQuerySearchNodesOnPullRequest {
                                    number: 5508,
                                    title: "[AI-910] sync rust defrag schema",
                                    url: "https://github.com/<REMOVED>/services/pull/5508",
                                    review_decision: None,
                                },
                            ),
                        ),
                        Some(
                            PullRequest(
                                SearchQuerySearchNodesOnPullRequest {
                                    number: 5410,
                                    title: "Add ooo for scheduler input",
                                    url: "https://github.com/<REMOVED>/services/pull/5410",
                                    review_decision: None,
                                },
                            ),
                        ),
                        Some(
                            PullRequest(
                                SearchQuerySearchNodesOnPullRequest {
                                    number: 5319,
                                    title: "first pass, create subclasses of movable events",
                                    url: "https://github.com/<REMOVED>/services/pull/5319",
                                    review_decision: None,
                                },
                            ),
                        ),
                    ],
                ),
            },
        },
    ),
    errors: None,
    extensions: None,
}

Token Settings
Screenshot 2023-08-13 at 1 52 03 PM

Pending From SPR list
Screenshot 2023-08-11 at 5 33 22 PM

Browsing PR status
Screenshot 2023-08-13 at 1 55 50 PM

gh pr view 5508
Screenshot 2023-08-13 at 1 58 47 PM

@eko-wibowo
Copy link
Author

any pointers / suggestions on how to debug this further would be awesome :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant