Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug: landing a PR after being accepted then re-ordered does not work #166

Open
dukeofcool199 opened this issue May 10, 2023 · 0 comments
Open

Comments

@dukeofcool199
Copy link

when a PR that is higher up on the stack is accepted, and then re-ordered so that it can be landed, complains about not being accepted. (this only happens for people who do not have permission to override the peer review requirements)

steps to reproduce:

  1. create commit A
  2. create commit B -- NOTE: these are independent commits
  3. spr diff --all
  4. accept Commit/PR B
  5. re-order local main so that B is below A
  6. spr land commit B
  7. get error stating that PR has not been accepted

seems to be similar if not the same issue as #163 (comment), but I thought I should put up my own issue in case they were different.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant