refactor!: generalize one eval to arbitrary lengths #381
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iajoiner
force-pushed
the
refactor/lengths
branch
from
5f8967a to
33ee01e
Compare
iajoiner
force-pushed
the
refactor/lengths
branch
2 times, most recently
from
9d87859 to
2eb1d15
Compare
JayWhite2357
requested changes
Nov 22, 2024
iajoiner
force-pushed
the
refactor/lengths
branch
5 times, most recently
from
160a15a to
27218fe
Compare
iajoiner
force-pushed
the
refactor/lengths
branch
2 times, most recently
from
98b06ed to
a85b1b5
Compare
iajoiner
force-pushed
the
refactor/lengths
branch
3 times, most recently
from
5ff0e59 to
35442f3
Compare
iajoiner
force-pushed
the
refactor/lengths
branch
3 times, most recently
from
56030f1 to
41f7e9b
Compare
iajoiner
force-pushed
the
refactor/lengths
branch
from
5bb0b21 to
e345a91
Compare
JayWhite2357
requested changes
Nov 27, 2024
| @@ -282,6 +298,7 @@ pub(super) fn prove_filter<'a, S: Scalar + 'a>( | |||
| n: usize, | |||
| m: usize, | |||
| ) { | |||
| builder.push_one_evaluation_length(m); | |||
There was a problem hiding this comment.
This is inside the prove_filter, but the corresponding consume is outside the verify_filter. Functionally it is correct, but we should keep the prove and verify mirrored. Either move them both in, or move them both out.
JayWhite2357
requested changes
Dec 2, 2024
| @@ -82,9 +82,9 @@ pub fn prover_evaluate_sign<'a, S: Scalar>( | |||
| builder: &mut FinalRoundBuilder<'a, S>, | |||
| alloc: &'a Bump, | |||
| expr: &'a [S], | |||
| table_length: usize, | |||
There was a problem hiding this comment.
You should just use expr.len().
| @@ -178,6 +180,7 @@ impl<CP: CommitmentEvaluationProof> QueryProof<CP> { | |||
|
|
|||
| let proof = Self { | |||
| bit_distributions: builder.bit_distributions().to_vec(), | |||
| one_evaluation_lengths: builder.one_evaluation_lengths().to_vec(), | |||
There was a problem hiding this comment.
These lengths need to be passed to make_transcript in order for the proof to be secure.
Comment on lines
289
to
291
| .chain(self.one_evaluation_lengths.clone().iter()) | ||
| .copied() | ||
| .collect::<Vec<_>>(); |
There was a problem hiding this comment.
NIT: there is a lot of clone/copy/collect here. At least some of them can be avoided.
iajoiner
force-pushed
the
refactor/lengths
branch
from
22ef5ff to
e64a6cc
Compare
iajoiner
force-pushed
the
refactor/lengths
branch
from
e64a6cc to
87185fd
Compare
iajoiner
force-pushed
the
refactor/lengths
branch
2 times, most recently
from
636fe8d to
61ff4b5
Compare
iajoiner
force-pushed
the
refactor/lengths
branch
from
61ff4b5 to
cb8be29
Compare
JayWhite2357
approved these changes
Dec 2, 2024
|
🎉 This PR is included in version 0.51.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
iajoiner
added a commit
that referenced
this pull request
Dec 4, 2024
Please be sure to look over the pull request guidelines here: https://github.com/spaceandtimelabs/sxt-proof-of-sql/blob/main/CONTRIBUTING.md#submit-pr. # Please go through the following checklist - [x] The PR title and commit messages adhere to guidelines here: https://github.com/spaceandtimelabs/sxt-proof-of-sql/blob/main/CONTRIBUTING.md. In particular `!` is used if and only if at least one breaking change has been introduced. - [x] I have run the ci check script with `source scripts/run_ci_checks.sh`. - The following upstream PRs have been merged: - [x] #381 - [x] #401 - [x] #404 # Rationale for this change This PR replaces #121 and is designed to test whether our `ProofPlan`s are truly composable now. <!-- Why are you proposing this change? If this is already explained clearly in the linked issue then this section is not needed. Explaining clearly why changes are proposed helps reviewers understand your changes and offer better suggestions for fixes. Example: Add `NestedLoopJoinExec`. Closes #345. Since we added `HashJoinExec` in #323 it has been possible to do provable inner joins. However performance is not satisfactory in some cases. Hence we need to fix the problem by implement `NestedLoopJoinExec` and speed up the code for `HashJoinExec`. --> # What changes are included in this PR? - add `SliceExec`. <!-- There is no need to duplicate the description in the ticket here but it is sometimes worth providing a summary of the individual changes in this PR. Example: - Add `NestedLoopJoinExec`. - Speed up `HashJoinExec`. - Route joins to `NestedLoopJoinExec` if the outer input is sufficiently small. --> # Are these changes tested? <!-- We typically require tests for all PRs in order to: 1. Prevent the code from being accidentally broken by subsequent changes 2. Serve as another way to document the expected behavior of the code If tests are not included in your PR, please explain why (for example, are they covered by existing tests)? Example: Yes. --> Yes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please be sure to look over the pull request guidelines here: https://github.com/spaceandtimelabs/sxt-proof-of-sql/blob/main/CONTRIBUTING.md#submit-pr.
Please go through the following checklist
!is used if and only if at least one breaking change has been introduced.source scripts/run_ci_checks.sh.table_lengthtoFirstRoundBuilder#380 has been merged.Rationale for this change
When
ProofPlans compose it makes no sense to havetable_lengthinVerificationBuilder. Instead it becomes necessary to record each and every instance of length used for one_eval and pass the info to the verifier.What changes are included in this PR?
VerificationBuilder::table_lengthinput_lengthandoutput_lengthto arbitrary lengthssingleton_one_evaluationtoSumcheckMleEvaluationsVerificationBuilderTableEvaluationone_evalas an arg toProofExpr::verifier_evaluateTableEvaluationinProofPlan::verifier_evaluate(Table<'a, S>, Vec<usize>)inProofPlan::result_evaluateto return one eval lengthsrange_lengthlogic fromFirstRoundBuilderasProofPlan::result_evaluatealready tracks potentially large output lengths in intermediate tablesAre these changes tested?
Yes.