feat: add SliceExec
#379
Merged
feat: add SliceExec
#379
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
iajoiner
force-pushed
the
feat/slice
branch
3 times, most recently
from
9bb93c2 to
557c669
Compare
iajoiner
force-pushed
the
feat/slice
branch
2 times, most recently
from
740e736 to
a72a118
Compare
iajoiner
force-pushed
the
feat/slice
branch
8 times, most recently
from
3d02d68 to
d3228e0
Compare
iajoiner
force-pushed
the
feat/slice
branch
4 times, most recently
from
36eda67 to
fc8fddd
Compare
2 tasks
iajoiner
force-pushed
the
feat/slice
branch
5 times, most recently
from
652726c to
66dea02
Compare
JayWhite2357
requested changes
Dec 3, 2024
|
For my reference: the review was over 86abb7c. |
iajoiner
force-pushed
the
feat/slice
branch
5 times, most recently
from
dd5ff6d to
e4bb220
Compare
JayWhite2357
force-pushed
the
feat/slice
branch
from
e4bb220 to
3bb2268
Compare
JayWhite2357
previously approved these changes
Dec 4, 2024
There was a problem hiding this comment.
FYI: I rebased after #404.
Approved.
I turned of auto-merge so you can address the NITs before merging.
JayWhite2357
approved these changes
Dec 4, 2024
|
🎉 This PR is included in version 0.55.1 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please be sure to look over the pull request guidelines here: https://github.com/spaceandtimelabs/sxt-proof-of-sql/blob/main/CONTRIBUTING.md#submit-pr.
Please go through the following checklist
!is used if and only if at least one breaking change has been introduced.source scripts/run_ci_checks.sh.result_evaluateback tofirst_round_evaluate#404Rationale for this change
This PR replaces #121 and is designed to test whether our
ProofPlans are truly composable now.What changes are included in this PR?
SliceExec.Are these changes tested?
Yes.