Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add Table && TableTestAccessor && table utilities #364

Merged
merged 4 commits into from
Nov 12, 2024
Merged

Conversation

iajoiner
Copy link
Contributor

@iajoiner iajoiner commented Nov 11, 2024

Please be sure to look over the pull request guidelines here: https://github.com/spaceandtimelabs/sxt-proof-of-sql/blob/main/CONTRIBUTING.md#submit-pr.

Please go through the following checklist

Rationale for this change

In order to make ProofPlans composable it is helpful to add Table which will replace DataAccessor in ProofExpr. In order to add tests that aren't too tedious it is necessary to add table utilities analogous to owned table ones.

What changes are included in this PR?

  • add Table
  • add table utilities in table_utility.rs
  • add `TableTestAccessor

Are these changes tested?

Yes.

@iajoiner iajoiner changed the title feat: add Table feat: add Table && table utilities Nov 11, 2024
@iajoiner iajoiner force-pushed the feat/table branch 3 times, most recently from 8255579 to d928871 Compare November 11, 2024 15:53
@iajoiner iajoiner marked this pull request as ready for review November 11, 2024 15:53
@iajoiner iajoiner enabled auto-merge November 11, 2024 15:58
@iajoiner iajoiner changed the title feat: add Table && table utilities feat: add Table && TableTestAccessor && table utilities Nov 11, 2024
@iajoiner iajoiner force-pushed the feat/table branch 4 times, most recently from 1899880 to 1d5903e Compare November 12, 2024 15:33
@iajoiner iajoiner merged commit 0f65802 into main Nov 12, 2024
11 checks passed
Copy link

🎉 This PR is included in version 0.43.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@iajoiner iajoiner deleted the feat/table branch November 12, 2024 19:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants